Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gmpy2 package #22927

Closed
vinklein mannequin opened this issue May 2, 2017 · 60 comments
Closed

Update gmpy2 package #22927

vinklein mannequin opened this issue May 2, 2017 · 60 comments
Assignees
@vinklein
Labels
c: packages: optional p: major / 3 t: enhancement
Milestone
sage-8.2

Comments

@vinklein
Copy link
Mannequin

vinklein mannequin commented May 2, 2017

Update gmpy2 package to have access to the gmpy2 C API.

Tarball : gmpy2-2.1.0a1.tar.gz

This gmpy2 version provides a Cython interface.

CC: @videlec

Component: packages: optional

Keywords: thursdaysbdx

Author: Vincent Klein

Branch/Commit: e000563

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/22927
@vinklein vinklein mannequin added this to the sage-8.0 milestone May 2, 2017
@vinklein vinklein mannequin self-assigned this May 2, 2017
@vinklein
Copy link
Mannequin Author

vinklein mannequin commented May 3, 2017

Branch: u/vklein/add_gmpy2_as_an_optional_package

@videlec
Copy link
Contributor

videlec commented May 3, 2017

comment:3

Note that gmpy2 was already an optional package. The title and description of the ticket are not be appropriate.

New commits:

e4be884use a snapshot version of gmpy2

@videlec
Copy link
Contributor

videlec commented May 3, 2017

Commit: e4be884

@vinklein

This comment has been minimized.

Sign in to view
@vinklein
Copy link
Mannequin Author

vinklein mannequin commented May 3, 2017

New commits:

e4be884use a snapshot version of gmpy2

@vinklein

This comment has been minimized.

Sign in to view
@vinklein

This comment has been minimized.

Sign in to view
@vinklein

This comment has been minimized.

Sign in to view
@vinklein

This comment has been minimized.

Sign in to view
@vinklein vinklein mannequin changed the title Add gmpy2 as an optional package Update gmpy2 package May 3, 2017
@videlec
Copy link
Contributor

videlec commented May 11, 2017

Changed keywords from none to jsb++

@videlec
Copy link
Contributor

videlec commented May 11, 2017

Changed keywords from jsb++ to thursdaysbdx

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 12, 2017

Changed commit from e4be884 to 4f604c3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 12, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

4f604c3update checksum, snapshot version update in setup.py

@vinklein
Copy link
Mannequin Author

vinklein mannequin commented May 12, 2017

comment:12

The version in the snapshot's setup.py was incorrect. ​https://www.labri.fr/perso/vklein/gmpy2-snapshot-02.05.17.tar.gz ans checksum.ini have been updated

@videlec
Copy link
Contributor

videlec commented May 17, 2017

comment:13

See gmpy pull request #134 for making mpz(a) and mpq(a) call the methods .__mpz__() and .__mpq__() respectively.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 22, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

ead4b30Merge branch ticket 22927 into 22928
d11c6afConversion between gmpy2 and sage integers
4a1c92eupdate checksum, snapshot version update in setup.py
87578d9Add path of gmpy2 in include_dirs
f1e9fe5Merge branch 'u/vklein/add_gmpy2_as_an_optional_package' of git://trac.sagemath.org/sage into t/22928/conversion_between_gmpy2_and_sage_integers
86560dfNew snapshot version, update checksum and package-version.txt

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 22, 2017

Changed commit from 4f604c3 to 86560df

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 22, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

164e398New snapshot version, update checksum and package-version.txt

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 22, 2017

Changed commit from 86560df to 164e398

@vinklein
Copy link
Mannequin Author

vinklein mannequin commented May 22, 2017

comment:16

New snapshot version gmpy2-snapshot-22.05.17.tar.gz, checksum has been updated.

@vinklein

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link

comment:19

Why the change in component? If you want to make it standard, it should be discussed on sage-devel.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 23, 2017

Changed commit from c199ba8 to 7e3505a

@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Jun 23, 2017

comment:32

Update snapshot version to gmpy2-snapshot-23.06.17.tar.gz

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 13, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d6072cause a snapshot version of gmpy2
ce7a082update checksum, snapshot version update in setup.py
2eca651New snapshot version, update checksum and package-version.txt
bd257c1Update checksum and snapshot version
32cc1abtrac 22927 update gmpy2 snapshot version
aab4169trac 22927 update gmpy2 package version

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 13, 2017

Changed commit from 7e3505a to aab4169

@jdemeyer
Copy link

Replying to @vinklein:

For now the check of the package fail

In that case, I'm not sure whether the package can be accepted. At a minimum, could you add a patch to disable the failing tests, such that gmpy2 at least formally passes its testsuite?

Second, you should better document how you obtained this tarball. Posting a tarball on your personal home page without further explanation is not sufficient. Is there any chance you could convince upstream to make a proper release? That would of course be much better.

Note that you have never set this ticket to needs_review. If you want this to be merged in Sage, you'll need to do that.

@vinklein

This comment has been minimized.

Sign in to view
@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Nov 13, 2017

comment:35

Is there any chance you could convince upstream to make a proper release?

Our goal has always be to have a proper release of gmpy2. It look like things are progressing well these last weeks. You can look at issue #146 if you want more specifics.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 14, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

0ba3ffbtrac 22927: update package version to snapshot-14.11.17

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 14, 2017

Changed commit from aab4169 to 0ba3ffb

@vinklein

This comment has been minimized.

Sign in to view
@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Nov 14, 2017

comment:37

update package version to gmpy2-snapshot-14.11.17.tar.gz

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 17, 2017

Changed commit from 0ba3ffb to a7bdad6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 17, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a7bdad6Trac #22927: update package version to snapshot-14.11.17

@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Nov 17, 2017

comment:39

rebase on 8.1.rc0 and squash commit

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 24, 2017

Changed commit from a7bdad6 to e000563

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 24, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e000563Trac #22927 gmpy2 update package version to 2.1.0a1

@vinklein

This comment has been minimized.

Sign in to view
@vinklein vinklein mannequin added the s: needs review label Nov 24, 2017
@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link

comment:44

Running make ptestlong now, but I don't expect any problems.

@videlec
Copy link
Contributor

videlec commented Nov 24, 2017

comment:45

(me too (running ptestlong))

@videlec videlec modified the milestones: sage-8.0, sage-8.2 Nov 24, 2017
@videlec
Copy link
Contributor

videlec commented Nov 24, 2017

comment:47

Replying to @videlec:

(me too (running ptestlong))

good for me!

@vbraun
Copy link
Member

vbraun commented Dec 11, 2017

Changed branch from u/vklein/add_gmpy2_as_an_optional_package to e000563

@vbraun vbraun closed this as completed in 1a59bbb Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinklein vinklein

Labels
c: packages: optional p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.2
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @videlec