Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct the test for galpol package in pari's spkg-configure.m4 #28405

Closed
dimpase opened this issue Aug 26, 2019 · 10 comments
Closed

correct the test for galpol package in pari's spkg-configure.m4 #28405

dimpase opened this issue Aug 26, 2019 · 10 comments

Comments

@dimpase
Copy link
Member

dimpase commented Aug 26, 2019

the test written there

if test "x$gp_galp_check = xC3\ \:\ C4"; then

always evaluates to true.
It is meant to check whether gp_galp_check (which may be empty) equals the string
"C3 : C4"

CC: @embray @kiwifb @isuruf @videlec

Component: build: configure

Author: Dima Pasechnik

Branch/Commit: 7d01e58

Reviewer: Isuru Fernando

Issue created by migration from https://trac.sagemath.org/ticket/28405

@dimpase dimpase added this to the sage-8.9 milestone Aug 26, 2019
@dimpase

This comment has been minimized.

@dimpase
Copy link
Member Author

dimpase commented Aug 26, 2019

comment:1

my patchy knowledge of autoconf/m4/shell syntax does not suffice, please help...

@kiwifb
Copy link
Member

kiwifb commented Aug 26, 2019

comment:2

Shouldn't it be

"x$gp_galp_check" = "xC3 : C4"

?

@dimpase
Copy link
Member Author

dimpase commented Aug 26, 2019

Branch: u/dimpase/packages/paritestfix

@dimpase
Copy link
Member Author

dimpase commented Aug 26, 2019

Author: Dima Pasechnik

@dimpase
Copy link
Member Author

dimpase commented Aug 26, 2019

Commit: 7d01e58

@dimpase
Copy link
Member Author

dimpase commented Aug 26, 2019

comment:3

I've moved the test into the call to gp, now it works.


New commits:

7d01e58let gp do the check and return 0/1

@isuruf
Copy link
Member

isuruf commented Sep 1, 2019

Reviewer: Isuru Fernando

@isuruf
Copy link
Member

isuruf commented Sep 1, 2019

comment:5

I can confirm the issue and that this ticket correctly detects that galpol is not installed.

@vbraun
Copy link
Member

vbraun commented Sep 5, 2019

Changed branch from u/dimpase/packages/paritestfix to 7d01e58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants