Skip to content

Commit

Permalink
Trac #28405: correct the test for galpol package in pari's spkg-confi…
Browse files Browse the repository at this point in the history
…gure.m4

the test written there
{{{#!bash
if test "x$gp_galp_check = xC3\ \:\ C4"; then
}}}
always evaluates to true.
It is meant to check whether `gp_galp_check` (which may be empty) equals
the string
`"C3 : C4"`

URL: https://trac.sagemath.org/28405
Reported by: dimpase
Ticket author(s): Dima Pasechnik
Reviewer(s): Isuru Fernando
  • Loading branch information
Release Manager committed Sep 4, 2019
2 parents ba9135f + 7d01e58 commit 7b98f47
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions build/pkgs/pari/spkg-configure.m4
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ SAGE_SPKG_CONFIGURE([pari], [
sage_spkg_install_pari=yes
fi
AC_MSG_CHECKING([is pari_galpol installed? ])
gp_galp_check=`echo "galoisgetname(12,1)" | $GP -qf 2>> config.log`
if test "x$gp_galp_check = xC3\ \:\ C4"; then
gp_galp_check=`echo "galoisgetname(12,1) == \"C3 : C4\"" | $GP -qf 2>> config.log`
if test x$gp_galp_check = x1; then
AC_MSG_RESULT([yes])
else
AC_MSG_RESULT([no; cannot use system pari/GP without galpol package])
Expand Down

0 comments on commit 7b98f47

Please sign in to comment.