Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Sage 9.2: Remove Python 2 support from the build system and CI scripts #29669

Closed
mkoeppe opened this issue May 9, 2020 · 17 comments
Closed

Comments

@mkoeppe
Copy link
Member

mkoeppe commented May 9, 2020

The ticket makes it an error (with a clear message) when ./configure --with-python=2 is invoked.

checking Python version to install... configure: error: the only allowed value for --with-python is 3.  Support for Python 2 has been removed in Sage 9.2.

The ticket keeps variables such as SAGE_PYTHON_VERSION and SAGE_PYTHON3 unchanged, for compatibility.

Also, to clarify in light of the discussion in https://groups.google.com/d/msg/sage-devel/fgsSsJmVVXo/ZIcJq9x3AAAJ, this ticket does not affect which versions of Python are sufficient as sage-system-python (this is still all versions listed in build/tox.ini, which includes various 2.x and 3.x).

Part of meta-ticket #29141.

Depends on #29633

CC: @dimpase @orlitzky @embray @fchapoton @jhpalmieri @vbraun

Component: build

Author: Matthias Koeppe

Branch/Commit: ff41817

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/29669

@mkoeppe mkoeppe added this to the sage-9.2 milestone May 9, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented May 9, 2020

Dependencies: #29633

@mkoeppe
Copy link
Member Author

mkoeppe commented May 9, 2020

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 9, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

96a5e76Remove python2 from tox and [GitHub](../wiki/GitHub) CI scripts

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 9, 2020

Commit: 96a5e76

@mkoeppe mkoeppe changed the title For Sage 9.2: Remove Python 2 support from the build system For Sage 9.2: Remove Python 2 support from the build system and CI scripts May 9, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented May 9, 2020

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

@orlitzky
Copy link
Contributor

orlitzky commented May 9, 2020

Reviewer: Michael Orlitzky

@orlitzky
Copy link
Contributor

orlitzky commented May 9, 2020

comment:7

This was never quite right,

case "$with_python" in
     3*) SAGE_PYTHON_VERSION=3;;

because it accepts --with-python=3.9 and ignores everything after the 3 (it should throw an error in my opinion). Not a big deal now since it will be deleted soon.

There's a lot of other python-2.x stuff to be removed in the build system, scripts, docs, and SPKGs, but I think you are aware of that and plan to deal with it later? If so this is fine as a first step.

@mkoeppe
Copy link
Member Author

mkoeppe commented May 9, 2020

comment:8

Replying to @orlitzky:

This was never quite right,

case "$with_python" in
     3*) SAGE_PYTHON_VERSION=3;;

because it accepts --with-python=3.9 and ignores everything after the 3 (it should throw an error in my opinion).

Good point. Let me make this a warning actually.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 9, 2020

Changed commit from 96a5e76 to ff41817

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 9, 2020

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

ea7df3econfigure.ac: Remove message 'Checking for Python version to install...'
ff41817configure.ac: Warn on 'configure --with-python=3.x'

@mkoeppe
Copy link
Member Author

mkoeppe commented May 9, 2020

comment:10

Replying to @orlitzky:

There's a lot of other python-2.x stuff to be removed in the build system, scripts, docs, and SPKGs, but I think you are aware of that and plan to deal with it later? If so this is fine as a first step.

Yes, there's a lot to be done, and there is a meta-ticket for that: #29141.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented May 9, 2020

comment:13

Thanks!

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@vbraun
Copy link
Member

vbraun commented May 29, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants