-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For Sage 9.2: Remove Python 2 support from the build system and CI scripts #29669
Comments
Dependencies: #29633 |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Commit: |
Author: Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
Reviewer: Michael Orlitzky |
comment:7
This was never quite right,
because it accepts There's a lot of other python-2.x stuff to be removed in the build system, scripts, docs, and SPKGs, but I think you are aware of that and plan to deal with it later? If so this is fine as a first step. |
comment:8
Replying to @orlitzky:
Good point. Let me make this a warning actually. |
comment:10
Replying to @orlitzky:
Yes, there's a lot to be done, and there is a meta-ticket for that: #29141. |
This comment has been minimized.
This comment has been minimized.
comment:13
Thanks! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Changed branch from u/mkoeppe/for_sage_9_2__remove_python_2_support_from_the_build_system to |
The ticket makes it an error (with a clear message) when
./configure --with-python=2
is invoked.The ticket keeps variables such as
SAGE_PYTHON_VERSION
andSAGE_PYTHON3
unchanged, for compatibility.Also, to clarify in light of the discussion in https://groups.google.com/d/msg/sage-devel/fgsSsJmVVXo/ZIcJq9x3AAAJ, this ticket does not affect which versions of Python are sufficient as
sage-system-python
(this is still all versions listed inbuild/tox.ini
, which includes various 2.x and 3.x).Part of meta-ticket #29141.
Depends on #29633
CC: @dimpase @orlitzky @embray @fchapoton @jhpalmieri @vbraun
Component: build
Author: Matthias Koeppe
Branch/Commit:
ff41817
Reviewer: Michael Orlitzky
Issue created by migration from https://trac.sagemath.org/ticket/29669
The text was updated successfully, but these errors were encountered: