-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github/workflows/tox-gcc_spkg.yml: Remove python2 #29757
Comments
Dependencies: #29669 |
Last 10 new commits:
|
Commit: |
Author: Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
comment:5
Could you rebase this on #29754 - which removes several Py2 packages this ticket touches. |
comment:6
Actually #29669 did and is already on Volker's branch. |
comment:7
This ticket here really only has 1 commit |
comment:8
Needs review |
Reviewer: Jonathan Kliem |
comment:9
LGTM. |
comment:10
Sorry, there is a mistake I believe. - tox_packages_factor: [minimal-gcc_spkg, standard-gcc_spkg, standard-python2-gcc_spkg]
+ tox_packages_factor: [minimal-gcc_spkg, standard-gcc_spkg, standard] This third option should probably go completely. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:12
Indeed, thanks for catching this. |
comment:14
Now it should be good to go. |
comment:15
Thanks! |
Changed branch from u/mkoeppe/_github_workflows_tox_gcc_spkg_yml__remove_python2 to |
Follow-up from #29669
Depends on #29669
CC: @dimpase @jhpalmieri @kliem
Component: porting
Author: Matthias Koeppe
Branch/Commit:
eac7eca
Reviewer: Jonathan Kliem
Issue created by migration from https://trac.sagemath.org/ticket/29757
The text was updated successfully, but these errors were encountered: