Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove packages that handle backporting from Python 3 to Python 2 #29754

Closed
jhpalmieri opened this issue May 28, 2020 · 55 comments
Closed

Remove packages that handle backporting from Python 3 to Python 2 #29754

jhpalmieri opened this issue May 28, 2020 · 55 comments
Labels
c: packages: standard p: major / 3 t: enhancement
Milestone
sage-9.2

Comments

@jhpalmieri
Copy link
Member

Remove

  • backports_abc
  • backports_functools_lru_cache
  • backports_shutil_get_terminal_size
  • backports_ssl_match_hostname
  • configparser
  • enum34
  • functools32
  • future
  • ipaddress
  • pathlib2
  • singledispatch
  • subprocess32
  • typing

Let's also remove sagenb, since it doesn't build with Python 3. That lets us remove

  • flask
  • flask_autoindex
  • flask_babel
  • flask_oldsessions
  • flask_openid
  • flask_silk
  • sagenb
  • twisted (it may be used by terminado when it is present, but terminado seems to function fine without it)
  • werkzeug

Component: packages: standard

Keywords: sd109

Author: John Palmieri

Branch/Commit: 0578937

Reviewer: Dima Pasechnik, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/29754
@jhpalmieri jhpalmieri added this to the sage-9.2 milestone May 28, 2020
@dimpase
Copy link
Member

dimpase commented May 28, 2020

comment:1

sagenb should go, too, it doesn't work in py3.

@jhpalmieri

This comment has been minimized.

Sign in to view
@jhpalmieri

This comment has been minimized.

Sign in to view
@jhpalmieri
Copy link
Member Author

Dependencies: #29752

@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/werkzeug-optional

@jhpalmieri
Copy link
Member Author

Commit: 27b3d91

@jhpalmieri
Copy link
Member Author

New commits:

56444d6trac 29752: convert werkzeug from standard to optional
27b3d91trac 29754: remove packages backported Python 3 components to Python 2.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ddca85atrac 29752: convert werkzeug from standard to optional

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Changed commit from 27b3d91 to ddca85a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Changed commit from ddca85a to 27b3d91

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

56444d6trac 29752: convert werkzeug from standard to optional
27b3d91trac 29754: remove packages backported Python 3 components to Python 2.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Changed commit from 27b3d91 to 9385b73

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ddca85atrac 29752: convert werkzeug from standard to optional
9385b73trac 29754: remove packages backported Python 3 components to Python

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Changed commit from 9385b73 to ddca85a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e1a0c8ctrac 29752: convert werkzeug from standard to optional
406a030trac 29754: remove packages backported Python 3 components to Python

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Changed commit from ddca85a to 406a030

@jhpalmieri
Copy link
Member Author

comment:12

I have to test my new branch. I'll set it back to "needs review" when that's done.

@jhpalmieri
Copy link
Member Author

Changed branch from u/jhpalmieri/werkzeug-optional to none

@jhpalmieri
Copy link
Member Author

Changed dependencies from #29752 to none

@jhpalmieri
Copy link
Member Author

Changed commit from 406a030 to none

@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/no-py2-backports

@jhpalmieri
Copy link
Member Author

Commit: 2903b22

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 6, 2020

comment:26

Conflicts with #29745

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 6, 2020

Changed branch from u/jhpalmieri/no-py2-backports to u/mkoeppe/no-py2-backports

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 6, 2020

Changed reviewer from Dima Pasechnik to Dima Pasechnik, Matthias Koeppe

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 6, 2020

New commits:

4672d55trac 29633: fixes for PDF docbuilding
2ee9befMerge tag '9.1' into t/29633/src_doc_bootstrap__generate_list_of_packages__with_links_to_documentation__for_ref_manual_from_build_pkgs
9c7ea5ftrac 29633: fix SQLite doctests in cmdline.py
8baef11trac 29745: clean up various SPKG.rst files
c559f26Merge branch 't/29669/for_sage_9_2__remove_python_2_support_from_the_build_system' into t/29745/cleanup-spkg-rst-files
05a6937Merge commit 'c559f26caf56378c8c4a5652f577986b4f5d431c' of git://trac.sagemath.org/sage into t/29754/no-py2-backports

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 6, 2020

Changed commit from c182f48 to 05a6937

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 7, 2020

comment:29

Follow-up: #29823

@jhpalmieri
Copy link
Member Author

comment:30

Another follow-up: #29878

@jhpalmieri
Copy link
Member Author

comment:31

And another: #29885 (remove "sage -n sagenb" as an advertised option, and strip the SageNB code from the sage-notebook script).

@vbraun
Copy link
Member

vbraun commented Jun 24, 2020

comment:32

Merge conflict

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2020

Changed commit from 05a6937 to cc61541

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2020

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

8387b7badd forgotten doctest fix.
2ddcd31change upstream_url to a (hopefully) more stable and easy to decipher address for sphinx packages
649289emove sphinx packages from pip to PYTHON_TOOLCHAIN
e5415datrac 28856: fix apostrophes in wikipedia links
b9d44e3Merge branch 'ticket-28000' into sphinx3
8f66113Minor upgdrade to Sphinx 3.0.3
321e2bfBump to 3.0.4
ee7195cMerge branch 'matplotlib3.2.1' into sphinx3
bd99462Merge branch 'develop' into sphinx3
cc61541Merge commit 'bd99462f6f89757b9b1674fbeb55743ce7f6fab6' of git://trac.sagemath.org/sage into t/29754/no-py2-backports

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 25, 2020

Changed dependencies from #29757 to #29757, #28856

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 26, 2020

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

0578937Merge tag '9.2.beta2' into t/29754/no-py2-backports

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 26, 2020

Changed commit from cc61541 to 0578937

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 26, 2020

Changed dependencies from #29757, #28856 to none

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 26, 2020

comment:36

merged in the latest beta

@vbraun
Copy link
Member

vbraun commented Jun 27, 2020

Changed branch from u/mkoeppe/no-py2-backports to 0578937

@vbraun vbraun closed this as completed in 876b682 Jun 27, 2020
@jhpalmieri jhpalmieri mentioned this issue Jul 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
4 participants
@vbraun @dimpase @jhpalmieri @mkoeppe