-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the downward monotonic cone to the cone catalogue #30200
Comments
Branch: u/mjo/ticket/30200 |
Last 10 new commits:
|
Commit: |
Author: Michael Orlitzky |
comment:2
This looks clean but I am not sure how widespread the name "downward monotonic cone" really is. Google finds only 10 hits of this phrase (and 0 hits for "downward monotone cone"). In fact, looking at the ticket I somehow expected to see an implementation of the nonpositive orthant... So how about calling it |
comment:3
Replying to @mkoeppe:
I tortured myself about this name for hours in order to include a split-second mention of it in a recent paper. The first application of it is to isotone or isotonic regression, where of course "iso" only means "same" and doesn't specify the direction. More recently and in other contexts, "monotone" has become more popular but suffers the same problem. You can find the ambiguous "monotone cone" in recent work on cone projections by Németh et al., for example. In any case, I'm forced to add an adjective to either of those, which have the only claim to being "official." I've chosen "downward monotonic" because it's the only option that
So even though there aren't that many mentions of it, the name "downward monotonic" at least appears in a few published papers, and then always to mean the cone that I've implemented. The "cone of nonincreasing sequences" on the other hand, has been used instead to refer to the same cone in a little-ell space. "Isotonic" has likewise been used much more generally. Finally, at least Gourion and Seeger have defined the "upward monotonic cone" officially, so if in the future we need to add its counterpart we have a reference for that. |
comment:4
Replying to @orlitzky:
Well, the factory could be generalized to |
comment:5
"nonincreasing sequences" is indeed a better name, but I'd rather not come up with Yet Another Name for the thing unless it's a spectacularly better name, or the name change is forced on us by some (e.g.) python restriction. No one has ever called it the cone of nonincreasing sequences before, so it's hard for me to justify making up a new name whose only google hits will be in the sage documentation. (Note that "downward monotonic" already appears in the docs for the Schur cone.) |
comment:6
Replying to @orlitzky:
This is unsubstantiated. Note that it is not a "new name" of a cone. It is a description of its elements -- which is immediately accessible to anyone who has taken a calculus class. |
comment:7
Replying to @mkoeppe:
Indeed, Niezgoda also calls it the cone of nonincreasing sequences once in "Bifractional inequalities and convex cones," but that's the only paper I was able to find using that name.
To match the other adjective-form names I would prefer "nonincreasing sequential," but I still think "downward monotonic" is a more evocative name. If we ever wind up with both, having "nonincreasing sequential" and "nondecreasing sequential" where the "increasing" one is decreasing and the "decreasing" one is increasing is more confusing than it has to be. The notation for the downward monotonic cone also justifies its name; the symbol In any case, I'm not prepared to argue about this forever. I didn't invent the cone, and isotonic/monotonic are the common names for it, with "monotonic" going back at least to Hardy, Littlewood, and Polya. I see no good reason to rename it (beyond the necessary mention of the direction of monotonicity) in sage. |
comment:8
The cone of nonincreasing sequences is an "everyday" mathematical object. If we add it to Sage, it should be named in a way that is as universally understood -- not using jargon from a narrow list of papers. By the way, also "monotonic cone" only has 21 Google hits (I know, I know, Polya was more a fan of Bing than of Google search), and "monotone cone" only 70. |
comment:9
This doesn't "need work" any more now than it would if I changed the name. Your own search results show that I've chosen the more popular name of the two, and this for inclusion in a catalogue of cones whose sole purpose is to make them easily accessible by name. Please just let someone else review it. |
comment:10
Replying to @orlitzky:
of what two? |
comment:11
downward monotonic cone and cone of nonincreasing sequences |
comment:13
Setting new milestone based on a cursory review of ticket status, priority, and last modification date. |
comment:14
Setting a new milestone for this ticket based on a cursory review. |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
This an an old PR that I never migrated from trac. We have a catalogue of convex cones accessible through `cones.foo()`, and this PR adds the downward monotonic cone to the catalogue. It will also close sagemath#30200. URL: sagemath#37802 Reported by: Michael Orlitzky Reviewer(s): Matthias Köppe
This an an old PR that I never migrated from trac. We have a catalogue of convex cones accessible through `cones.foo()`, and this PR adds the downward monotonic cone to the catalogue. It will also close sagemath#30200. URL: sagemath#37802 Reported by: Michael Orlitzky Reviewer(s): Matthias Köppe
Depends on #30128
Depends on #30153
Depends on #32877
Component: geometry
Author: Michael Orlitzky
Branch/Commit: u/mjo/ticket/30200 @
7268365
Issue created by migration from https://trac.sagemath.org/ticket/30200
The text was updated successfully, but these errors were encountered: