-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix conversion of GAP univariate rat functions, which are polynomial with valuation>0 #30496
Comments
comment:1
discovered by chance, while working on #29314 |
This comment has been minimized.
This comment has been minimized.
Branch: u/chapoton/30496 |
Author: Frédéric Chapoton |
comment:3
here is a proposal New commits:
|
Commit: |
comment:4
could you write this
This is less ugly. |
Changed branch from u/chapoton/30496 to public/packages/30496 |
comment:5
OK, good. New commits:
|
Reviewer: Dima Pasechnik |
Changed branch from public/packages/30496 to |
oops. This is due to
where 3rd
1
is valuation v, so that the function is xv(2/1)=2x.But the corresponding code added in #21020
forgets about the case of valuation>0.
CC: @fchapoton @tscrim
Component: interfaces
Author: Frédéric Chapoton
Branch/Commit:
c582e80
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/30496
The text was updated successfully, but these errors were encountered: