update GAP to version 4.11, libsemigroup to 1.0.9 #29314

dimpase · 2020-03-11T11:12:19Z

GAP 4.11.0 and libsemigroup 1.3.1 have been released.
(we pick libsemigroup 1.0.9 as the one compatible with GAP's 4.11 semigroups package)

tarball: see upstream_url fields

CC: @antonio-rojas @timokau @soehms @tobiasdiez

Component: packages: standard

Author: Dima Pasechnik

Branch/Commit: a28138c

Reviewer: Matthias Koeppe, Tobias Diez

Issue created by migration from https://trac.sagemath.org/ticket/29314

The text was updated successfully, but these errors were encountered:

mkoeppe · 2020-03-12T00:41:42Z

comment:3

Does the upgrade fix #28728?

antonio-rojas · 2020-03-15T20:53:01Z

comment:4

Besides changes in tests output, there's only one small change needed due to the VERSION alias removal. Patch at https://aur.archlinux.org/cgit/aur.git/tree/sagemath-gap-4.11.patch?h=sagemath-git

I haven't tested the gap-packages update

dimpase · 2020-09-02T17:01:28Z

Author: Dima Pasechnik

dimpase · 2020-09-02T17:01:28Z

Commit: 1b80d95

dimpase · 2020-09-02T17:01:28Z

New commits:

`47c42d0`	`version bumps, checksums, patch removal, packages: updated names`
`1b80d95`	`libsemigroups update`

dimpase · 2020-09-02T17:01:28Z

Branch: u/dimpase/packages/gap411

sagetrac-git · 2020-09-02T17:20:43Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`f361b88`	`libsemigroups update`

sagetrac-git · 2020-09-02T17:20:43Z

Changed commit from 1b80d95 to f361b88

dimpase · 2020-09-02T17:52:00Z

comment:8

sage -t --warn-long 105.7 --random-seed=0 src/sage/libs/gap/element.pyx  # 6 doctests failed
sage -t --warn-long 105.7 --random-seed=0 src/sage/libs/gap/libgap.pyx  # 1 doctest failed

something to be fixed 1st

dimpase · 2020-09-02T20:55:31Z

Dependencies: #30496

sagetrac-git · 2020-09-02T21:36:10Z

Changed commit from f361b88 to 8429a9c

sagetrac-git · 2020-09-02T21:36:10Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`82191ca`	`fix conversion from gap polynomial with valence > 0`
`c582e80`	`better syntax for libgap calls`
`bbd7419`	`version bumps, checksums, patch removal, packages: updated names`
`87c6a6b`	`libsemigroups update`
`8429a9c`	`patches from Arch (cf #29314)`

sagetrac-git · 2020-09-02T21:50:29Z

Branch pushed to git repo; I updated commit sha1. New commits:

`08193ae`	`tagged #random tests with output depending upon gap_packages installed`

sagetrac-git · 2020-09-02T21:50:29Z

Changed commit from 8429a9c to 08193ae

sagetrac-git · 2020-09-02T22:51:52Z

Branch pushed to git repo; I updated commit sha1. New commits:

`c90360b`	`one more doctest fix`

sagetrac-git · 2020-09-02T22:51:52Z

Changed commit from 08193ae to c90360b

sagetrac-git · 2020-09-03T08:53:18Z

Changed commit from c90360b to 2121141

sagetrac-git · 2020-09-03T08:53:18Z

Branch pushed to git repo; I updated commit sha1. New commits:

`2121141`	`more robust test, so that GAP's packages don't matter`

dimpase · 2020-09-03T13:55:24Z

comment:14

there seems to be one failing doctest that is macOS-specific, in src/sage/groups/cubic_braid.py,
but I still think we have to proceed (it's probably a platform-specific GAP bug).

dimpase · 2020-10-13T14:10:14Z

comment:97

perhaps buildbot hanging is a multithreading issue - libgap in not multithreaded, calling it from several threads is asking for trouble: gap-system/gap#2893 (comment)

dimpase · 2020-10-16T13:11:57Z

comment:98

we should move PackageManager GAP package from gap_packages to gap - it is small and useful.

dimpase · 2020-11-10T17:55:14Z

comment:99

The ball here is in Volker's court. I have no idea why his buildbots hang.

mkoeppe · 2020-11-12T02:20:15Z

Changed reviewer from Matthias Koeppe to Matthias Koeppe, ...

slel · 2020-11-14T09:46:02Z

comment:101

Replying to @dimpase:

we should move PackageManager GAP package from gap_packages to gap - it is small and useful.

+1 -- separate ticket or here?

dimpase · 2020-11-14T09:49:15Z

comment:102

Replying to @slel:

Replying to @dimpase:

we should move PackageManager GAP package from gap_packages to gap - it is small and useful.

+1 -- separate ticket or here?

I'll do it here - it's still "needs review" after all.

dimpase · 2020-11-14T09:55:28Z

Changed commit from 47fcc16 to 9836f79

dimpase · 2020-11-14T09:55:28Z

Changed branch from u/jhpalmieri/packages/gap411 to u/dimpase/packages/gap411

dimpase · 2020-11-14T09:55:28Z

Changed dependencies from #30720 to none

dimpase · 2020-11-14T09:59:00Z

comment:104

rebased over the latest beta, moved PackageManager GAP package as discussed.

tobiasdiez · 2020-11-17T21:48:01Z

comment:105

I've used this ticket in #30371, and it runs well on the github action (https://github.com/tobiasdiez/sage/runs/1413136300?check_suite_focus=true). In particular, there was no "hanging" or multithreading problem.

The only gap related doc tests that fail are:

2020-11-17T17:27:35.4675866Z sage -t --random-seed=0 /__w/sage/sage/src/sage/interfaces/gap_workspace.py
2020-11-17T17:27:35.4676910Z **********************************************************************
2020-11-17T17:27:35.4677821Z File "/__w/sage/sage/src/sage/interfaces/gap_workspace.py", line 55, in sage.interfaces.gap_workspace.gap_workspace_file
2020-11-17T17:27:35.4681873Z Failed example:
2020-11-17T17:27:35.4683784Z     name1 = Popen([sys.executable, '-c', cmd], stdout=PIPE).communicate()[0]
2020-11-17T17:27:35.4684739Z Expected nothing
2020-11-17T17:27:35.4685235Z Got:
2020-11-17T17:27:35.4686344Z     /__w/sage/sage/src/sage/calculus/functional.py:57: DeprecationWarning: invalid escape sequence \d
2020-11-17T17:27:35.4687468Z       """
2020-11-17T17:27:39.4060681Z **********************************************************************
2020-11-17T17:27:39.4062343Z File "/__w/sage/sage/src/sage/interfaces/gap_workspace.py", line 56, in sage.interfaces.gap_workspace.gap_workspace_file
2020-11-17T17:27:39.4063371Z Failed example:
2020-11-17T17:27:39.4065030Z     name2 = Popen([sys.executable, '-c', cmd], stdout=PIPE).communicate()[0]
2020-11-17T17:27:39.4065813Z Expected nothing
2020-11-17T17:27:39.4066315Z Got:
2020-11-17T17:27:39.4067147Z     /__w/sage/sage/src/sage/calculus/functional.py:57: DeprecationWarning: invalid escape sequence \d
2020-11-17T17:27:39.4067993Z       """
2020-11-17T17:27:39.4129689Z **********************************************************************

But that could also very well be a result of the somewhat unusual setup of #30371.
So from my side this looks good.

tobiasdiez · 2020-11-17T21:48:01Z

Changed reviewer from Matthias Koeppe, ... to Matthias Koeppe, Tobias Diez, ...

dimpase · 2020-11-18T14:13:57Z

comment:106

Replying to @tobiasdiez:

I've used this ticket in #30371, and it runs well on the github action (https://github.com/tobiasdiez/sage/runs/1413136300?check_suite_focus=true). In particular, there was no "hanging" or multithreading problem.

The only gap related doc tests that fail are:

Thanks.
I can't reproduce these, they don't seem to originate from this ticket.

mkoeppe · 2020-12-08T22:49:33Z

Changed branch from u/dimpase/packages/gap411 to u/mkoeppe/packages/gap411

mkoeppe · 2020-12-08T23:46:19Z

Changed reviewer from Matthias Koeppe, Tobias Diez, ... to Matthias Koeppe, Tobias Diez, https://github.com/mkoeppe/sage/actions/runs/409420323

mkoeppe · 2020-12-08T23:46:19Z

New commits:

`a28138c`	`Merge tag '9.3.beta3' into t/29314/packages/gap411`

mkoeppe · 2020-12-08T23:46:19Z

Changed commit from 9836f79 to a28138c

mkoeppe · 2020-12-10T01:04:22Z

comment:109

Looks all fine on GH Actions. (comment:25 of course still applies)

mkoeppe · 2020-12-10T01:04:22Z

Changed reviewer from Matthias Koeppe, Tobias Diez, https://github.com/mkoeppe/sage/actions/runs/409420323 to Matthias Koeppe, Tobias Diez

vbraun · 2020-12-13T20:31:08Z

Changed branch from u/mkoeppe/packages/gap411 to a28138c

upgrades our corresponding spkgs: * gap * gap_packages * libsemigroups * Previous upgrades: - #31498: GAP 4.11.1 - #29314: GAP 4.11, libsemigroup 1.0.9 * Upstream: Completely fixed; Fix reported upstream Closes #34391 URL: #35093 Reported by: Dima Pasechnik Reviewer(s): Gonzalo Tornaría, Matthias Köppe

dimpase added this to the sage-9.1 milestone Mar 11, 2020

dimpase added c: packages: standard labels Mar 11, 2020

mkoeppe modified the milestones: sage-9.1, sage-9.2 May 4, 2020

This comment has been minimized.

Sign in to view

dimpase changed the title ~~update GAP to version 4.11~~ update GAP to version 4.11, libsemigroup to 1.3.1 Sep 2, 2020

This comment has been minimized.

Sign in to view

dimpase changed the title ~~update GAP to version 4.11, libsemigroup to 1.3.1~~ update GAP to version 4.11, libsemigroup to 1.0.9 Sep 2, 2020

dimpase added the s: needs review label Sep 3, 2020

dimpase added s: needs review and removed s: needs work labels Nov 10, 2020

mkoeppe added s: positive review and removed s: needs review labels Dec 10, 2020

vbraun removed the s: positive review label Dec 13, 2020

vbraun closed this as completed in 5f46b34 Dec 13, 2020

dimpase mentioned this issue Jun 20, 2021

upgrade GAP to 4.11.1 or newer #31498

Closed

slel mentioned this issue Jan 27, 2023

Upgrade: GAP 4.12 #34391

Closed

dimpase mentioned this issue Feb 12, 2023

update GAP to 4.12.2 #35093

Merged

update GAP to version 4.11, libsemigroup to 1.0.9 #29314

update GAP to version 4.11, libsemigroup to 1.0.9 #29314

Comments

dimpase commented Mar 11, 2020

mkoeppe commented Mar 12, 2020

antonio-rojas commented Mar 15, 2020

dimpase commented Sep 2, 2020

This comment has been minimized.

dimpase commented Sep 2, 2020

dimpase commented Sep 2, 2020

dimpase commented Sep 2, 2020

sagetrac-git mannequin commented Sep 2, 2020

sagetrac-git mannequin commented Sep 2, 2020

This comment has been minimized.

dimpase commented Sep 2, 2020

dimpase commented Sep 2, 2020

sagetrac-git mannequin commented Sep 2, 2020

sagetrac-git mannequin commented Sep 2, 2020

sagetrac-git mannequin commented Sep 2, 2020

sagetrac-git mannequin commented Sep 2, 2020

sagetrac-git mannequin commented Sep 2, 2020

sagetrac-git mannequin commented Sep 2, 2020

sagetrac-git mannequin commented Sep 3, 2020

sagetrac-git mannequin commented Sep 3, 2020

dimpase commented Sep 3, 2020

dimpase commented Oct 13, 2020

dimpase commented Oct 16, 2020

dimpase commented Nov 10, 2020

mkoeppe commented Nov 12, 2020

slel commented Nov 14, 2020

dimpase commented Nov 14, 2020

dimpase commented Nov 14, 2020

dimpase commented Nov 14, 2020

dimpase commented Nov 14, 2020

dimpase commented Nov 14, 2020

tobiasdiez commented Nov 17, 2020

tobiasdiez commented Nov 17, 2020

dimpase commented Nov 18, 2020

mkoeppe commented Dec 8, 2020

mkoeppe commented Dec 8, 2020

mkoeppe commented Dec 8, 2020

mkoeppe commented Dec 8, 2020

mkoeppe commented Dec 10, 2020

mkoeppe commented Dec 10, 2020

vbraun commented Dec 13, 2020