Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gmpy2 to add python 3.10 support #31855

Closed
mkoeppe opened this issue May 24, 2021 · 34 comments
Closed

Upgrade gmpy2 to add python 3.10 support #31855

mkoeppe opened this issue May 24, 2021 · 34 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented May 24, 2021

gmpy2 fails to build with Python 3.10: error: ‘_PyHASH_NAN’ undeclared - https://bugzilla.redhat.com/show_bug.cgi?id=1959010 ...

2.1.0rc1 has a fix.

Upstream: Fixed upstream, but not in a stable release.

CC: @videlec @dimpase @orlitzky @kiwifb

Component: packages: standard

Author: Matthias Koeppe

Branch: 41f7f4e

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/31855

@mkoeppe mkoeppe added this to the sage-9.4 milestone May 24, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented May 25, 2021

@mkoeppe
Copy link
Member Author

mkoeppe commented May 25, 2021

Commit: 8cd9ece

@mkoeppe
Copy link
Member Author

mkoeppe commented May 25, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented May 25, 2021

New commits:

8cd9ecebuild/pkgs/gmpy2/patches: Add patches from Fedora @python/python3.10

@videlec
Copy link
Contributor

videlec commented May 30, 2021

comment:3

Why not use upstream patch aleaxit/gmpy#297?

@mkoeppe
Copy link
Member Author

mkoeppe commented May 30, 2021

comment:4

No idea, why doesn't upstream make a proper release at some point?

@videlec
Copy link
Contributor

videlec commented May 30, 2021

comment:5

Replying to @mkoeppe:

No idea, why doesn't upstream make a proper release at some point?

No idea, worth asking. Though the patch was merged a week ago.

@dimpase
Copy link
Member

dimpase commented Jun 26, 2021

Upstream: Reported upstream. No feedback yet.

@dimpase
Copy link
Member

dimpase commented Jun 26, 2021

comment:7

Replying to @videlec:

Replying to @mkoeppe:

No idea, why doesn't upstream make a proper release at some point?

No idea, worth asking. Though the patch was merged a week ago.

I've opened
aleaxit/gmpy#303

@dimpase
Copy link
Member

dimpase commented Jun 26, 2021

comment:8

How about using the upstream patch https://patch-diff.githubusercontent.com/raw/aleaxit/gmpy/pull/297.diff
instead?

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 28, 2021

comment:10

Looks like upstream is preparing a proper release now - aleaxit/gmpy@9742452

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 15, 2021

Changed commit from 8cd9ece to 41f7f4e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 15, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

41f7f4ebuild/pkgs/gmpy2: Update to 2.1.0rc1

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Patch/upgrade gmpy2 to add python 3.10 support Upgrade gmpy2 to add python 3.10 support Sep 15, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 15, 2021

Changed upstream from Reported upstream. No feedback yet. to Fixed upstream, but not in a stable release.

@orlitzky
Copy link
Contributor

comment:16

OK by me when the GH actions finish. Everyone is already using beta5, so it's not like rc1 is a step down in purported release quality.

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 10, 2021

comment:17

Let's get this in please.

@enriqueartal
Copy link
Contributor

comment:18

I am in Fedora 35 now and I would like to test it. I can use python3.10 (following the hack of the packager of sagemath in Fedora) but I do not know how to deal with cysignals. Any clue?

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 3, 2021

comment:19

See #32576 for cysignals

@enriqueartal
Copy link
Contributor

comment:20

I saw it but I am not how to deal with it. Apparently in Fedora they were able to compile cysignals and to use it as a system package.

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 3, 2021

comment:21

You can help on #32576 by reviewing the proposed changes to cysignals

@enriqueartal
Copy link
Contributor

comment:22

This is the status. I used the configure file of sagemath.spec in fedora which allows to use python3.10.0 in the system. Using the link in #32576 I used the revised cysignals, and I also used gmpy2.1.0rc1, both are compiled. The only unsuccessful package is pyzmq; the fedora system package python3-zmq exists and I was able to recompile it locally. The error in Sage is:

gcc build/temp.linux-x86_64-3.9/tmp/timer_createq5lapz40.o -o build/temp.linux-x86_64-3.9/a.out
error: [Errno 2] No such file or directory: 'a.out'

It happens with 22.2.1 and 22.0.3
I do not know how to use the system package for this.

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 5, 2021

comment:23

I have opened #32828 for the issues with pyzmq. I think they are unrelated to python 3.10

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 8, 2021

comment:26

Tests look good, let's please get this update in.

@dimpase
Copy link
Member

dimpase commented Nov 17, 2021

@dimpase
Copy link
Member

dimpase commented Nov 17, 2021

comment:29

lgtm

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 17, 2021

comment:30

Thanks!

@vbraun
Copy link
Member

vbraun commented Dec 5, 2021

@dimpase
Copy link
Member

dimpase commented Dec 15, 2021

Changed commit from 41f7f4e to none

@dimpase
Copy link
Member

dimpase commented Dec 15, 2021

comment:32

gmpy2 stable version 2.1 has been released.

mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants