-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade gmpy2 to add python 3.10 support #31855
Comments
Commit: |
Author: Matthias Koeppe |
New commits:
|
comment:3
Why not use upstream patch aleaxit/gmpy#297? |
comment:4
No idea, why doesn't upstream make a proper release at some point? |
comment:5
Replying to @mkoeppe:
No idea, worth asking. Though the patch was merged a week ago. |
Upstream: Reported upstream. No feedback yet. |
comment:7
Replying to @videlec:
I've opened |
comment:8
How about using the upstream patch https://patch-diff.githubusercontent.com/raw/aleaxit/gmpy/pull/297.diff |
comment:10
Looks like upstream is preparing a proper release now - aleaxit/gmpy@9742452 |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
This comment has been minimized.
This comment has been minimized.
Changed upstream from Reported upstream. No feedback yet. to Fixed upstream, but not in a stable release. |
comment:16
OK by me when the GH actions finish. Everyone is already using beta5, so it's not like rc1 is a step down in purported release quality. |
comment:17
Let's get this in please. |
comment:18
I am in Fedora 35 now and I would like to test it. I can use python3.10 (following the hack of the packager of sagemath in Fedora) but I do not know how to deal with cysignals. Any clue? |
comment:19
See #32576 for cysignals |
comment:20
I saw it but I am not how to deal with it. Apparently in Fedora they were able to compile cysignals and to use it as a system package. |
comment:21
You can help on #32576 by reviewing the proposed changes to cysignals |
comment:22
This is the status. I used the configure file of sagemath.spec in fedora which allows to use python3.10.0 in the system. Using the link in #32576 I used the revised cysignals, and I also used gmpy2.1.0rc1, both are compiled. The only unsuccessful package is pyzmq; the fedora system package python3-zmq exists and I was able to recompile it locally. The error in Sage is: gcc build/temp.linux-x86_64-3.9/tmp/timer_createq5lapz40.o -o build/temp.linux-x86_64-3.9/a.out It happens with 22.2.1 and 22.0.3 |
comment:23
I have opened #32828 for the issues with |
comment:26
Tests look good, let's please get this update in. |
Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/1430376304, https://github.com/mkoeppe/sage/actions/runs/1430376300 to Dima Pasechnik |
comment:29
lgtm |
comment:30
Thanks! |
Changed branch from u/mkoeppe/patch_upgrade_gmpy2_to_add_python_3_10_support to |
Changed commit from |
comment:32
gmpy2 stable version 2.1 has been released. |
gmpy2
fails to build with Python 3.10: error: ‘_PyHASH_NAN’ undeclared - https://bugzilla.redhat.com/show_bug.cgi?id=1959010 ...2.1.0rc1 has a fix.
Upstream: Fixed upstream, but not in a stable release.
CC: @videlec @dimpase @orlitzky @kiwifb
Component: packages: standard
Author: Matthias Koeppe
Branch:
41f7f4e
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/31855
The text was updated successfully, but these errors were encountered: