Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove imports from sage.misc.all #32989

Closed
mkoeppe opened this issue Dec 7, 2021 · 9 comments
Closed

Remove imports from sage.misc.all #32989

mkoeppe opened this issue Dec 7, 2021 · 9 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 7, 2021

As the title says, we remove more imports from sage.misc.all.

CC: @kwankyu

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 1ab9441

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/32989

@mkoeppe mkoeppe added this to the sage-9.5 milestone Dec 7, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 7, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 7, 2021

Commit: 1ab9441

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 7, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 7, 2021

New commits:

2d9a84egit grep -l 'misc.all import' | xargs sed -i.bak 's/misc.all import tmp_/misc.temporary_file import tmp_/'
5a8d76eRemove imports from sage.misc.all
97b4dfdgit grep -l 'misc.all import' | xargs sed -i.bak 's/misc.all import sage_eval/misc.sage_eval import sage_eval/'
e72dc8eRemove more imports from sage.misc.all
d114096git grep -l 'misc.all import' | xargs sed -i.bak 's/misc.all import cartesian_product_iterator/misc.mrange import cartesian_product_iterator/'
1ab9441Remove remaining imports from sage.misc.all

@kwankyu
Copy link
Collaborator

kwankyu commented Dec 9, 2021

Reviewer: Kwankyu Lee

@kwankyu

This comment has been minimized.

@kwankyu
Copy link
Collaborator

kwankyu commented Dec 9, 2021

comment:4

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 9, 2021

comment:5

Thanks!

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Jan 10, 2022
@vbraun
Copy link
Member

vbraun commented Feb 12, 2022

Changed branch from u/mkoeppe/remove_imports_from_sage_misc_all to 1ab9441

@vbraun vbraun closed this as completed in b511685 Feb 12, 2022
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants