Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace \mbox by \text in manifolds #35353

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Conversation

tobiasdiez
Copy link
Contributor

📚 Description

vscode uses katex to render the latex output of jupyter cells. However, katex doesn't support mbox (see KaTeX/KaTeX#2050). Thus we replace \mbox with \text.

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: aca70fc

Copy link
Member

@egourgoulhon egourgoulhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.
I've checked the output of the html and pdf documentation and a few Jupyter notebooks with this branch.

@egourgoulhon
Copy link
Member

Can you explain the "Deploy Documentation" failure in the automated checks?

@tobiasdiez
Copy link
Contributor Author

Thanks for the review. The deployment workflow is currently broken (for all PRs) and hopefully fixed with #35356.

@vbraun vbraun merged commit ae417bb into sagemath:develop Apr 6, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants