Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement .interpolation() method for ProductTree #36456

Conversation

yyyyx4
Copy link
Member

@yyyyx4 yyyyx4 commented Oct 12, 2023

The ProductTree class has a .remainders() method which can, among other things, be used to implement the Fast Fourier Transform. In this patch we add a corresponding .interpolation() method, which can, among other things, be used to implement the inverse Fast Fourier Transform. Its functionality is equivalent to CRT_list(), but caching the product-tree structure makes it significantly faster for repeated invocations.

@yyyyx4 yyyyx4 force-pushed the public/implement_interpolation_method_for_product_trees branch from 1d5caad to 07e2c29 Compare December 26, 2023 20:49
@yyyyx4
Copy link
Member Author

yyyyx4 commented Dec 26, 2023

Thanks, done.

Copy link

Documentation preview for this PR (built with commit 07e2c29; changes) is ready! 🎉

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 27, 2023
    
The `ProductTree` class has a `.remainders()` method which can, among
other things, be used to implement the Fast Fourier Transform. In this
patch we add a corresponding `.interpolation()` method, which can, among
other things, be used to implement the *inverse* Fast Fourier Transform.
Its functionality is equivalent to `CRT_list()`, but caching the
product-tree structure makes it significantly faster for repeated
invocations.
    
URL: sagemath#36456
Reported by: Lorenz Panny
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 2, 2024
    
The `ProductTree` class has a `.remainders()` method which can, among
other things, be used to implement the Fast Fourier Transform. In this
patch we add a corresponding `.interpolation()` method, which can, among
other things, be used to implement the *inverse* Fast Fourier Transform.
Its functionality is equivalent to `CRT_list()`, but caching the
product-tree structure makes it significantly faster for repeated
invocations.
    
URL: sagemath#36456
Reported by: Lorenz Panny
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 5, 2024
    
The `ProductTree` class has a `.remainders()` method which can, among
other things, be used to implement the Fast Fourier Transform. In this
patch we add a corresponding `.interpolation()` method, which can, among
other things, be used to implement the *inverse* Fast Fourier Transform.
Its functionality is equivalent to `CRT_list()`, but caching the
product-tree structure makes it significantly faster for repeated
invocations.
    
URL: sagemath#36456
Reported by: Lorenz Panny
Reviewer(s): Kwankyu Lee
@vbraun vbraun merged commit 2552ba0 into sagemath:develop Jan 14, 2024
20 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Jan 14, 2024
@yyyyx4 yyyyx4 deleted the public/implement_interpolation_method_for_product_trees branch January 19, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants