-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement .interpolation() method for ProductTree #36456
Merged
vbraun
merged 2 commits into
sagemath:develop
from
yyyyx4:public/implement_interpolation_method_for_product_trees
Jan 14, 2024
Merged
implement .interpolation() method for ProductTree #36456
vbraun
merged 2 commits into
sagemath:develop
from
yyyyx4:public/implement_interpolation_method_for_product_trees
Jan 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyyyx4
force-pushed
the
public/implement_interpolation_method_for_product_trees
branch
from
November 10, 2023 13:16
f88f733
to
1d5caad
Compare
kwankyu
reviewed
Dec 8, 2023
kwankyu
reviewed
Dec 8, 2023
yyyyx4
force-pushed
the
public/implement_interpolation_method_for_product_trees
branch
from
December 26, 2023 20:49
1d5caad
to
07e2c29
Compare
Thanks, done. |
Documentation preview for this PR (built with commit 07e2c29; changes) is ready! 🎉 |
kwankyu
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM.
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 27, 2023
The `ProductTree` class has a `.remainders()` method which can, among other things, be used to implement the Fast Fourier Transform. In this patch we add a corresponding `.interpolation()` method, which can, among other things, be used to implement the *inverse* Fast Fourier Transform. Its functionality is equivalent to `CRT_list()`, but caching the product-tree structure makes it significantly faster for repeated invocations. URL: sagemath#36456 Reported by: Lorenz Panny Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 2, 2024
The `ProductTree` class has a `.remainders()` method which can, among other things, be used to implement the Fast Fourier Transform. In this patch we add a corresponding `.interpolation()` method, which can, among other things, be used to implement the *inverse* Fast Fourier Transform. Its functionality is equivalent to `CRT_list()`, but caching the product-tree structure makes it significantly faster for repeated invocations. URL: sagemath#36456 Reported by: Lorenz Panny Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 5, 2024
The `ProductTree` class has a `.remainders()` method which can, among other things, be used to implement the Fast Fourier Transform. In this patch we add a corresponding `.interpolation()` method, which can, among other things, be used to implement the *inverse* Fast Fourier Transform. Its functionality is equivalent to `CRT_list()`, but caching the product-tree structure makes it significantly faster for repeated invocations. URL: sagemath#36456 Reported by: Lorenz Panny Reviewer(s): Kwankyu Lee
yyyyx4
deleted the
public/implement_interpolation_method_for_product_trees
branch
January 19, 2024 10:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ProductTree
class has a.remainders()
method which can, among other things, be used to implement the Fast Fourier Transform. In this patch we add a corresponding.interpolation()
method, which can, among other things, be used to implement the inverse Fast Fourier Transform. Its functionality is equivalent toCRT_list()
, but caching the product-tree structure makes it significantly faster for repeated invocations.