-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement twisted homology of simplicial sets. #36691
Conversation
Multivariate Laurent Polynomial Ring in f2, f3 over Integer Ring | ||
sage: Y = simplicial_sets.RealProjectiveSpace(2) | ||
sage: Y._canonical_twisting_operator() | ||
{f: F1bar} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps delete lines 600 and 601, since they're covered in 603-604.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before the changes in universal_cover_dict
, these two examples behaved differently (the hashes of the simplices in the n-skeleton of a wedge didn't necessarily match the ones in the total space).
I think it is good to have a test that makes sure that that problem is solved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm talking about (a) a line that evaluates Y._canonical_twisting_operator()
as compared to (b) a line that does d2 = Y._canonical_twisting_operator()
and then evaluates d2
. Are you saying that those behaved differently? If so, it would be good to add a comment explaining that, or else someone may come along later, not understand their purpose, and delete those tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry, you are right. What worked differently was the example with X
. The lines you mention are indeed unnecessarily duplicated.
My first impression is that it adds important functionality to Sage, and it looks good. Should |
I have a design question: when I wrote the initial simplicial set code, I set it up so that This would allow moving some methods around between files, and it might make it possible to unify None of this would necessarily be done on this PR, but is it worth thinking about, or should we keep it as is? |
Co-authored-by: John H. Palmieri <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some small comments.
merge conflict |
Documentation preview for this PR (built with commit 82bea65; changes) is ready! 🎉 |
Fixed. |
Right now we can compute universal covers of simplicial sets if the fundamental group is finite. This PR implements
twisted homology with respect to the abelianization character.
In particular, if the fundamental group is abelian, this gives modules whose underlying additive group are isomorphic to the homology groups of the universal cover.
Addresses #36690
📝 Checklist