Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details in interfaces #36758

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Conversation

fchapoton
Copy link
Contributor

Just fixing a few suggestions of ruff and pycodestyle there

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

@@ -1930,7 +1934,7 @@ def atomic(self, lhs, op='=', rhs=0):

op = self._normalize_op(op)

formula = ('%r %s %r' % (lhs, op, rhs))
formula = (f'{lhs!r} {op} {rhs!r}')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
formula = (f'{lhs!r} {op} {rhs!r}')
formula = f'{lhs!r} {op} {rhs!r}'

Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@dcoudert dcoudert mentioned this pull request Nov 23, 2023
2 tasks
Copy link

Documentation preview for this PR (built with commit 6b94f66; changes) is ready! 🎉

Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 10, 2023
    
Just fixing a few suggestions of `ruff` and `pycodestyle` there

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36758
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
@vbraun vbraun merged commit 3d335fa into sagemath:develop Dec 14, 2023
20 of 21 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 14, 2023
@fchapoton fchapoton deleted the details_in_interfaces branch December 14, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants