-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove check for deprecated attribute _no_generic_basering_coercion #37115
Merged
vbraun
merged 1 commit into
sagemath:develop
from
pjbruin:remove_no_generic_basering_coercion
Feb 2, 2024
Merged
Remove check for deprecated attribute _no_generic_basering_coercion #37115
vbraun
merged 1 commit into
sagemath:develop
from
pjbruin:remove_no_generic_basering_coercion
Feb 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview for this PR (built with commit ae58cdd; changes) is ready! 🎉 |
mezzarobba
approved these changes
Jan 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 22, 2024
…asering_coercion In `sage.categories.unital_algebras.UnitalAlgebras`, remove the check for the attribute `_no_generic_basering_coercion`, which was deprecated in sagemath#19225. This means that this attribute is now completely ignored by the coercion framework. URL: sagemath#37115 Reported by: Peter Bruin Reviewer(s): Marc Mezzarobba
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 24, 2024
…asering_coercion In `sage.categories.unital_algebras.UnitalAlgebras`, remove the check for the attribute `_no_generic_basering_coercion`, which was deprecated in sagemath#19225. This means that this attribute is now completely ignored by the coercion framework. URL: sagemath#37115 Reported by: Peter Bruin Reviewer(s): Marc Mezzarobba
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 27, 2024
…asering_coercion In `sage.categories.unital_algebras.UnitalAlgebras`, remove the check for the attribute `_no_generic_basering_coercion`, which was deprecated in sagemath#19225. This means that this attribute is now completely ignored by the coercion framework. URL: sagemath#37115 Reported by: Peter Bruin Reviewer(s): Marc Mezzarobba
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 29, 2024
…asering_coercion In `sage.categories.unital_algebras.UnitalAlgebras`, remove the check for the attribute `_no_generic_basering_coercion`, which was deprecated in sagemath#19225. This means that this attribute is now completely ignored by the coercion framework. URL: sagemath#37115 Reported by: Peter Bruin Reviewer(s): Marc Mezzarobba
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 30, 2024
…asering_coercion In `sage.categories.unital_algebras.UnitalAlgebras`, remove the check for the attribute `_no_generic_basering_coercion`, which was deprecated in sagemath#19225. This means that this attribute is now completely ignored by the coercion framework. URL: sagemath#37115 Reported by: Peter Bruin Reviewer(s): Marc Mezzarobba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
sage.categories.unital_algebras.UnitalAlgebras
, remove the check for the attribute_no_generic_basering_coercion
, which was deprecated in #19225. This means that this attribute is now completely ignored by the coercion framework.