Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for deprecated attribute _no_generic_basering_coercion #37115

Merged

Conversation

pjbruin
Copy link
Contributor

@pjbruin pjbruin commented Jan 19, 2024

In sage.categories.unital_algebras.UnitalAlgebras, remove the check for the attribute _no_generic_basering_coercion, which was deprecated in #19225. This means that this attribute is now completely ignored by the coercion framework.

Copy link

Documentation preview for this PR (built with commit ae58cdd; changes) is ready! 🎉

Copy link
Member

@mezzarobba mezzarobba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 22, 2024
…asering_coercion

    
In `sage.categories.unital_algebras.UnitalAlgebras`, remove the check
for the attribute `_no_generic_basering_coercion`, which was deprecated
in sagemath#19225. This means that this attribute is now completely ignored by
the coercion framework.
    
URL: sagemath#37115
Reported by: Peter Bruin
Reviewer(s): Marc Mezzarobba
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 24, 2024
…asering_coercion

    
In `sage.categories.unital_algebras.UnitalAlgebras`, remove the check
for the attribute `_no_generic_basering_coercion`, which was deprecated
in sagemath#19225. This means that this attribute is now completely ignored by
the coercion framework.
    
URL: sagemath#37115
Reported by: Peter Bruin
Reviewer(s): Marc Mezzarobba
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 27, 2024
…asering_coercion

    
In `sage.categories.unital_algebras.UnitalAlgebras`, remove the check
for the attribute `_no_generic_basering_coercion`, which was deprecated
in sagemath#19225. This means that this attribute is now completely ignored by
the coercion framework.
    
URL: sagemath#37115
Reported by: Peter Bruin
Reviewer(s): Marc Mezzarobba
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 29, 2024
…asering_coercion

    
In `sage.categories.unital_algebras.UnitalAlgebras`, remove the check
for the attribute `_no_generic_basering_coercion`, which was deprecated
in sagemath#19225. This means that this attribute is now completely ignored by
the coercion framework.
    
URL: sagemath#37115
Reported by: Peter Bruin
Reviewer(s): Marc Mezzarobba
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 30, 2024
…asering_coercion

    
In `sage.categories.unital_algebras.UnitalAlgebras`, remove the check
for the attribute `_no_generic_basering_coercion`, which was deprecated
in sagemath#19225. This means that this attribute is now completely ignored by
the coercion framework.
    
URL: sagemath#37115
Reported by: Peter Bruin
Reviewer(s): Marc Mezzarobba
@vbraun vbraun merged commit 3c8640b into sagemath:develop Feb 2, 2024
21 of 23 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants