Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doctest in gap_packages (using empty table) #37147

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

fchapoton
Copy link
Contributor

This is fixing a misbehaviour of empty tables, in their new unicode clothes.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have created tests covering the changes.

Copy link

Documentation preview for this PR (built with commit 0935a0b; changes) is ready! 🎉

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 24, 2024
    
This is fixing a misbehaviour of empty tables, in their new unicode
clothes.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have created tests covering the changes.
    
URL: sagemath#37147
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 27, 2024
    
This is fixing a misbehaviour of empty tables, in their new unicode
clothes.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have created tests covering the changes.
    
URL: sagemath#37147
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 29, 2024
    
This is fixing a misbehaviour of empty tables, in their new unicode
clothes.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have created tests covering the changes.
    
URL: sagemath#37147
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 30, 2024
    
This is fixing a misbehaviour of empty tables, in their new unicode
clothes.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have created tests covering the changes.
    
URL: sagemath#37147
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit f33ba4d into sagemath:develop Feb 2, 2024
15 of 22 checks passed
@fchapoton fchapoton deleted the fix_empty_table branch February 3, 2024 08:18
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants