Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide Q.log(P) instead of P.discrete_log(Q) for elliptic-curve points #37152

Merged
merged 1 commit into from
Feb 2, 2024
Merged

provide Q.log(P) instead of P.discrete_log(Q) for elliptic-curve points #37152

merged 1 commit into from
Feb 2, 2024

Conversation

yyyyx4
Copy link
Member

@yyyyx4 yyyyx4 commented Jan 23, 2024

Here's an attempt to resolve #37150. I'm not suggesting to remove .discrete_log() any time soon, but I do feel this inconsistency should be corrected at some point, so we may as well start with it now.

Cc: @JohnCremona

@yyyyx4 yyyyx4 changed the title provide Q.log(P) in favour of P.discrete_log(Q) for elliptic-curve points provide Q.log(P) instead of P.discrete_log(Q) for elliptic-curve points Jan 23, 2024
@yyyyx4 yyyyx4 force-pushed the public/fix_EllipticCurvePoint_log_argument_order branch from 519ee04 to f150e92 Compare January 23, 2024 18:38
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit f150e92; changes) is ready! 🎉

JohnCremona
JohnCremona approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@JohnCremona JohnCremona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am all in favour of consistency. I am probably the culprit, since I remeber implementing this (and implementing the completely generic discrete log code using BSGS in any additive or multiplicative group, to this end).

@yyyyx4
Copy link
Member Author

yyyyx4 commented Jan 24, 2024

Thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 27, 2024
sagemathgh-37152: provide Q.log(P) instead of P.discrete_log(Q) for e…
c6e73ab 
…lliptic-curve points

    
Here's an attempt to resolve sagemath#37150. I'm not suggesting to remove
`.discrete_log()` any time soon, but I do feel this inconsistency should
be corrected *at some point*, so we may as well start with it now.

Cc: @JohnCremona
    
URL: sagemath#37152
Reported by: Lorenz Panny
Reviewer(s): John Cremona
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 29, 2024
sagemathgh-37152: provide Q.log(P) instead of P.discrete_log(Q) for e…
ee97f82 
…lliptic-curve points

    
Here's an attempt to resolve sagemath#37150. I'm not suggesting to remove
`.discrete_log()` any time soon, but I do feel this inconsistency should
be corrected *at some point*, so we may as well start with it now.

Cc: @JohnCremona
    
URL: sagemath#37152
Reported by: Lorenz Panny
Reviewer(s): John Cremona
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 30, 2024
sagemathgh-37152: provide Q.log(P) instead of P.discrete_log(Q) for e…
378bc72 
…lliptic-curve points

    
Here's an attempt to resolve sagemath#37150. I'm not suggesting to remove
`.discrete_log()` any time soon, but I do feel this inconsistency should
be corrected *at some point*, so we may as well start with it now.

Cc: @JohnCremona
    
URL: sagemath#37152
Reported by: Lorenz Panny
Reviewer(s): John Cremona
@vbraun vbraun merged commit 66d8cba into sagemath:develop Feb 2, 2024
18 of 25 checks passed
@yyyyx4 yyyyx4 deleted the public/fix_EllipticCurvePoint_log_argument_order branch February 3, 2024 12:57
@amanmoon amanmoon mentioned this pull request Feb 10, 2024
Merged
3 tasks
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 18, 2024
sagemathgh-37262: Added automatic size labeler
51f9eda 
    
I have implemented the `automatic size labeler`, which now assigns
labels to pull requests based on the number of lines changed

**Minimal**
Typically involves very small changes, bug fixes, or updates that
require only a few lines of code, often less than 50.
sagemath#37208 sagemath#37146 sagemath#37043

**Small**
Involves more substantial changes than minimal, potentially adding new
features or making modifications to existing ones. The range is usually
between 50 to 100 lines of code.
sagemath#37152 sagemath#37132

**Moderate**
Represents a significant portion of the codebase being modified, such as
adding new features, refactoring, or making extensive changes to
existing functionalities. This might involve between 100 to 300 lines of
code.
sagemath#36919 sagemath#37112

**Large**
Involves substantial and complex changes across various parts of the
codebase. This could include major architectural changes, the
introduction of new modules, or a significant overhaul of existing
features, often exceeding 300 lines of code.
sagemath#37125 sagemath#36977 sagemath#36972

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.

Fixes: sagemath#37254
    
URL: sagemath#37262
Reported by: Aman Moon
Reviewer(s): Sebastian Oehms
vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 20, 2024
sagemathgh-37262: Added automatic size labeler
4800287 
    
I have implemented the `automatic size labeler`, which now assigns
labels to pull requests based on the number of lines changed

**Minimal**
Typically involves very small changes, bug fixes, or updates that
require only a few lines of code, often less than 50.
sagemath#37208 sagemath#37146 sagemath#37043

**Small**
Involves more substantial changes than minimal, potentially adding new
features or making modifications to existing ones. The range is usually
between 50 to 100 lines of code.
sagemath#37152 sagemath#37132

**Moderate**
Represents a significant portion of the codebase being modified, such as
adding new features, refactoring, or making extensive changes to
existing functionalities. This might involve between 100 to 300 lines of
code.
sagemath#36919 sagemath#37112

**Large**
Involves substantial and complex changes across various parts of the
codebase. This could include major architectural changes, the
introduction of new modules, or a significant overhaul of existing
features, often exceeding 300 lines of code.
sagemath#37125 sagemath#36977 sagemath#36972

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.

Fixes: sagemath#37254
    
URL: sagemath#37262
Reported by: Aman Moon
Reviewer(s): Sebastian Oehms
vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 25, 2024
sagemathgh-37262: Added automatic size labeler
c315128 
    
I have implemented the `automatic size labeler`, which now assigns
labels to pull requests based on the number of lines changed

**Minimal**
Typically involves very small changes, bug fixes, or updates that
require only a few lines of code, often less than 50.
sagemath#37208 sagemath#37146 sagemath#37043

**Small**
Involves more substantial changes than minimal, potentially adding new
features or making modifications to existing ones. The range is usually
between 50 to 100 lines of code.
sagemath#37152 sagemath#37132

**Moderate**
Represents a significant portion of the codebase being modified, such as
adding new features, refactoring, or making extensive changes to
existing functionalities. This might involve between 100 to 300 lines of
code.
sagemath#36919 sagemath#37112

**Large**
Involves substantial and complex changes across various parts of the
codebase. This could include major architectural changes, the
introduction of new modules, or a significant overhaul of existing
features, often exceeding 300 lines of code.
sagemath#37125 sagemath#36977 sagemath#36972

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.

Fixes: sagemath#37254
    
URL: sagemath#37262
Reported by: Aman Moon
Reviewer(s): Sebastian Oehms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnCremona JohnCremona JohnCremona approved these changes

Assignees
No one assigned
Labels
c: elliptic curves p: minor / 4 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.

elliptic-curve points' .discrete_log() has its arguments swapped compared to all(?) other logarithms
4 participants
@yyyyx4 @JohnCremona @vbraun @mkoeppe