Add additional lattice methods for matrices over QQ #37157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On behalf of @grhkm21 I also made the docstring for BKZ over both ZZ and QQ a bit more descriptive |
grhkm21
reviewed
Jan 24, 2024
|
I think the changes in the review above has all been made (it was from two hours ago), so you can resolve those. I will wait for CI, but otherwise looks fine. |
|
Documentation preview for this PR (built with commit 80a2c2f; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 27, 2024
LLL has long been implemented for matrices over QQ by clearing the
denominator and doing LLL over ZZ, but this was not done for BKZ() or
is_LLL_reduced()
This PR adds BKZ() and is_LLL_reduced() to rational matrices, using the
same techniques as the current LLL method.
URL: sagemath#37157
Reported by: TheBlupper
Reviewer(s): grhkm21
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 29, 2024
LLL has long been implemented for matrices over QQ by clearing the
denominator and doing LLL over ZZ, but this was not done for BKZ() or
is_LLL_reduced()
This PR adds BKZ() and is_LLL_reduced() to rational matrices, using the
same techniques as the current LLL method.
URL: sagemath#37157
Reported by: TheBlupper
Reviewer(s): grhkm21
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 30, 2024
LLL has long been implemented for matrices over QQ by clearing the
denominator and doing LLL over ZZ, but this was not done for BKZ() or
is_LLL_reduced()
This PR adds BKZ() and is_LLL_reduced() to rational matrices, using the
same techniques as the current LLL method.
URL: sagemath#37157
Reported by: TheBlupper
Reviewer(s): grhkm21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLL has long been implemented for matrices over QQ by clearing the denominator and doing LLL over ZZ, but this was not done for BKZ() or is_LLL_reduced()
This PR adds BKZ() and is_LLL_reduced() to rational matrices, using the same techniques as the current LLL method.