-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix univariate polynomial reverse #37201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks good to me. |
xcaruso
approved these changes
Jan 30, 2024
Minor fix: the change of the error message (upon negative input value) affects a doctest in matrix_polynomial_dense, this is fixed. |
Documentation preview for this PR (built with commit 9f15f69; changes) is ready! 🎉 |
5 tasks
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 1, 2024
…in corner case For univariate polynomial matrices, either with zero columns (or zero rows if `row_wise=False`), or which are zero, the computed minimal kernel basis was of the sparse type (due to a mistake in using the identity method). This is fixed. - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies PR sagemath#37201 modified a test in the same file `matrix_polynomial_dense.pyx` URL: sagemath#37208 Reported by: Vincent Neiger Reviewer(s): Vincent Neiger, Xavier Caruso
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For univariate polynomials over "non-prime" finite fields, the reverse method had an issue when specifying
degree=0
: it raised an error saying that this optional argument should be... nonnegative (which 0 is).Example:
This is fixed in this PR, along with fixes in similar code where the error message was not the expected one ("cannot convert to long", instead of "degree must be nonnegative").