Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix small mistake in BQFClassGroupQuotientMorphism documentation #37233

Conversation

yyyyx4
Copy link
Member

@yyyyx4 yyyyx4 commented Feb 3, 2024

The possibility to pass discriminants to the constructor instead of BQFClassGroup objects was present for an earlier version of #37074, but it was removed during review. However, it seems I forgot to update the docstring accordingly.

Copy link

github-actions bot commented Feb 3, 2024

Documentation preview for this PR (built with commit 07bb20a; changes) is ready! 🎉

@yyyyx4 yyyyx4 requested a review from tscrim February 3, 2024 16:24
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 7, 2024
…documentation

    
The possibility to pass discriminants to the constructor instead of
`BQFClassGroup` objects was present for an earlier version of sagemath#37074,
but it was removed during review. However, it seems I forgot to update
the docstring accordingly.
    
URL: sagemath#37233
Reported by: Lorenz Panny
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit 4f78a5f into sagemath:develop Feb 13, 2024
24 of 25 checks passed
@yyyyx4 yyyyx4 deleted the public/fix_small_mistake_in_BQFClassGroupQuotientMorphism_documentation branch February 14, 2024 02:58
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants