-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
large pep8 cleanup in interfaces #37273
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchapoton
added
s: needs review
c: interfaces
t: refactoring
and removed
t: refactoring
labels
Feb 10, 2024
kwankyu
reviewed
Feb 18, 2024
kwankyu
reviewed
Feb 18, 2024
kwankyu
reviewed
Feb 18, 2024
kwankyu
reviewed
Feb 18, 2024
kwankyu
reviewed
Feb 18, 2024
kwankyu
reviewed
Feb 18, 2024
kwankyu
reviewed
Feb 18, 2024
kwankyu
reviewed
Feb 18, 2024
kwankyu
reviewed
Feb 18, 2024
kwankyu
reviewed
Feb 18, 2024
kwankyu
reviewed
Feb 18, 2024
kwankyu
reviewed
Feb 18, 2024
Otherwise lgtm. |
Please rebase as well. |
fchapoton
force-pushed
the
pep8_clean_interfaces
branch
from
February 18, 2024 19:37
cd436b3
to
d12bfbc
Compare
Documentation preview for this PR (built with commit d12bfbc; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 19, 2024
just fixing many small code details in `interfaces` folder ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#37273 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just fixing many small code details in
interfaces
folder📝 Checklist