Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better subs on piecewise functions #38706

Merged
merged 3 commits into from
Sep 29, 2024
Merged

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Sep 24, 2024

This will allow to change variable for another variable in piecewise functions.

This will fix #22102

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

Copy link

github-actions bot commented Sep 24, 2024

Documentation preview for this PR (built with commit 0fb7081; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@user202729
Copy link
Contributor

Technically after this change the comment

        If the substitution changes the piecewise variable, it must
        evaluate to a number so that we know which component we are
        on::

is no longer true. (Although it wasn't true previously either, .subs(x=x) was previously allowed)

vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 27, 2024
    
This will allow to change variable for another variable in piecewise
functions.

This will fix sagemath#22102

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38706
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit bd2a006 into sagemath:develop Sep 29, 2024
21 checks passed
@fchapoton fchapoton deleted the subs_of_piecewise branch September 29, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Substitutions inside piecewise functions don't work
4 participants