-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matroids
: Add certificate
argument to is_valid
#38711
Conversation
Documentation preview for this PR (built with commit f6e506b; changes) is ready! 🎉 |
That's a nice addition, thanks. Could it be a good idea to have an iterator that provides the errors? |
From my experience, one usually needs only one failure in order to unravel the invalidity and fix it. Although it is possible that having all errors provides some utility, I think that would be marginal; one not worth the code complication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks! |
When certificate is set to
True
, the methodis_valid
returns a tuple of a boolean and a dictionary.The dictionary provides some more information in case the matroid is not valid.
Examples:
To be done constistently with #38024.