This repository has been archived by the owner on Jan 30, 2023. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Trac #33193: redeclare val_unit() in padic subclasses that override it.
When overriding a C method to add optional parameters in Cython, you have to re-declare the method in the corresponding subclass pxd file; otherwise, you'll get warnings like those that Cython is throwing: warning: sage/rings/padics/CR_template.pxi:1478:10: Compatible but non-identical C method 'val_unit' not redeclared in definition part of extension type 'CRElement'. This may cause incorrect vtables to be generated. In this case, things are a bit convoluted due to templates being used, but the solution still boils down to re-declaring the subclass methods with the additional optional argument.
- Loading branch information