Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAASMLOPS-910 Build Bytewax Image in cloudbees #12

Merged
merged 13 commits into from
Feb 2, 2024

Conversation

brijesh-vora-sp
Copy link

@brijesh-vora-sp brijesh-vora-sp commented Jan 30, 2024

The Bytewax image was building successfully locally but had some problems with scm_version in cloudbees. This PR fixes that.

Cloudbees dev: https://cloudbees-core.ops-dev-use1.cloud.sailpoint.com/identity-ai/view/Tarragon/job/bytewax-image-build/
Cloudbees utils: https://cloudbees-core.ops-util-use1.utility.cloud.sailpoint.com/build/job/MLOps/job/bytewax-image-build/

@brijesh-vora-sp brijesh-vora-sp marked this pull request as draft January 30, 2024 16:25
@brijesh-vora-sp brijesh-vora-sp changed the title SAASMLOPS-910 fix the scm_version SAASMLOPS-910 Build Bytewax Image in cloudbees Jan 30, 2024
@brijesh-vora-sp brijesh-vora-sp marked this pull request as ready for review January 30, 2024 22:34
@brijesh-vora-sp brijesh-vora-sp requested a review from a team January 30, 2024 22:50
pyproject.toml Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@brijesh-vora-sp
Copy link
Author

@alex-vinnik-sp created a separate dockerfile and now the cloudbees would use that file to create the build.

Copy link

@alex-vinnik-sp alex-vinnik-sp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 just a few minor comments

sailpoint-bytewax.dockerfile Show resolved Hide resolved
@alex-vinnik-sp
Copy link

@brijesh-vora-sp please update the doc as well with new step-by-step instructions what job to use, etc.

@alex-vinnik-sp
Copy link

aws ecr list-images --repository-name 'sailpoint/feast-bytewax'
{
    "imageIds": []
}

🤔

@brijesh-vora-sp
Copy link
Author

The image-ids are null as the I just created a ECR Repo named sailpoint/feast-bytewax. The original was sailpoint/bytewax where the old bytewax images are stored.

@brijesh-vora-sp brijesh-vora-sp merged commit 2dafa44 into master Feb 2, 2024
15 checks passed
@brijesh-vora-sp brijesh-vora-sp deleted the brijesh.vora/SAASMLOPS-910 branch April 24, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants