Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for python 3.8 #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update for python 3.8 #6

wants to merge 4 commits into from

Conversation

rolveb
Copy link

@rolveb rolveb commented Mar 9, 2021

Fixed compilation errros by renaming tp_print to tp_vectorcall_offset and added prefix to tstate -> type, value and traceback
tstate->curexc_type = type;
tstate->curexc_value = value;
tstate->curexc_traceback = tb;

@jaysonlarose
Copy link

Woohoo! This version works! ♥

Thank you for going through the code, so I don't have to!

@decryptozoo
Copy link

decryptozoo commented Jul 1, 2021

Could this please be merged? Master is broken. Otherwise we should declare @rolveb as the new allmighty maintainer. The guy who did something. His fork should be cherished. For now.

For people who want to get things done and move on:

pip install git+https://github.com/rolveb/PySixel.git

@Davidy22
Copy link

I kind of want to depend on this for something I have. @rolveb, are you interested in uploading your version to pypi or taking the namespace on pypi from the current project?

@lubosz
Copy link

lubosz commented Oct 16, 2023

Not sure why you did these changes manually, you can just call cython to regenerate:

cython sixel/converter.py -o sixel/sixel_cimpl.c

As seen in the Makefile.

You can install my fork via:

pip install git+https://github.com/lubosz/PySixel.git

Works with Python 3.11 and for all eternity without having to update the C code every Cython update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants