Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ORG] RU-AXAV: 3.x: Move nullability annotations into the type argument declaration … #35

Closed
wants to merge 1 commit into from

Conversation

sakibguy
Copy link
Owner

…(ReactiveX#7303)

  • 3.x: Move nullability annotations into the type argument declaration

  • Reinforce Function<T, R> return argument type where R is non-trivial

Thank you for contributing to RxJava. Before pressing the "Create Pull Request" button, please consider the following points:

  • Please give a description about what and why you are contributing, even if it's trivial.

  • Please include the issue list number(s) or other PR numbers in the description if you are contributing in response to those.

  • Please include a reasonable set of unit tests if you contribute new code or change an existing one. If you contribute an operator, (if applicable) please make sure you have tests for working with an empty, just, range of values as well as an error source, with and/or without backpressure and see if unsubscription/cancellation propagates correctly.

…7303)

* 3.x: Move nullability annotations into the type argument declaration

* Reinforce Function<T, R> return argument type where R is non-trivial
@sakibguy sakibguy added bug Something isn't working documentation Improvements or additions to documentation labels Jul 25, 2021
@sakibguy sakibguy self-assigned this Jul 25, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #35 (40ca8ef) into 3.x (66fd701) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x      #35      +/-   ##
============================================
+ Coverage     99.52%   99.53%   +0.01%     
- Complexity     6782     6783       +1     
============================================
  Files           751      751              
  Lines         47489    47489              
  Branches       6378     6378              
============================================
+ Hits          47262    47268       +6     
+ Misses          104      101       -3     
+ Partials        123      120       -3     
Impacted Files Coverage Δ
...in/java/io/reactivex/rxjava3/core/Completable.java 100.00% <ø> (ø)
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100.00% <ø> (ø)
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100.00% <ø> (ø)
...ain/java/io/reactivex/rxjava3/core/Observable.java 100.00% <ø> (ø)
...rc/main/java/io/reactivex/rxjava3/core/Single.java 100.00% <ø> (ø)
...rnal/subscriptions/DeferredScalarSubscription.java 100.00% <ø> (ø)
...o/reactivex/rxjava3/parallel/ParallelFlowable.java 100.00% <ø> (ø)
...o/reactivex/rxjava3/processors/AsyncProcessor.java 100.00% <ø> (+2.08%) ⬆️
...va/io/reactivex/rxjava3/schedulers/Schedulers.java 100.00% <ø> (ø)
.../reactivex/rxjava3/subscribers/SafeSubscriber.java 100.00% <ø> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75e7e50...40ca8ef. Read the comment docs.

@sakibguy sakibguy closed this Jul 25, 2021
@sakibguy sakibguy changed the title 3.x: Move nullability annotations into the type argument declaration … RU-AXAV: 3.x: Move nullability annotations into the type argument declaration … Jan 27, 2023
@sakibguy sakibguy changed the title RU-AXAV: 3.x: Move nullability annotations into the type argument declaration … [ORG] RU-AXAV: 3.x: Move nullability annotations into the type argument declaration … Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants