Merge pull request #8 from parse-community/master

bump node version (parse-community#7441)
sakibguy · Jun 22, 2021 · 56d9e05 · 56d9e05
2 parents 9de8e53 + d8dc524
commit 56d9e05
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 11 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -7,7 +7,7 @@ on:
     branches:
       - '**'
 env:
-  NODE_VERSION: 14.17.0
+  NODE_VERSION: 14.17.1
   PARSE_SERVER_TEST_TIMEOUT: 20000
 jobs:
   check-ci:
@@ -97,28 +97,28 @@ jobs:
             MONGODB_VERSION: 4.4.6
             MONGODB_TOPOLOGY: replicaset
             MONGODB_STORAGE_ENGINE: wiredTiger
-            NODE_VERSION: 14.17.0
+            NODE_VERSION: 14.17.1
           - name: MongoDB 4.2, ReplicaSet, WiredTiger
             MONGODB_VERSION: 4.2.14
             MONGODB_TOPOLOGY: replicaset
             MONGODB_STORAGE_ENGINE: wiredTiger
-            NODE_VERSION: 14.17.0
+            NODE_VERSION: 14.17.1
           - name: MongoDB 4.0, ReplicaSet, WiredTiger
             MONGODB_VERSION: 4.0.25
             MONGODB_TOPOLOGY: replicaset
             MONGODB_STORAGE_ENGINE: wiredTiger
-            NODE_VERSION: 14.17.0
+            NODE_VERSION: 14.17.1
           - name: MongoDB 4.0, Standalone, MMAPv1
             MONGODB_VERSION: 4.0.25
             MONGODB_TOPOLOGY: standalone
             MONGODB_STORAGE_ENGINE: mmapv1
-            NODE_VERSION: 14.17.0
+            NODE_VERSION: 14.17.1
           - name: Redis Cache
             PARSE_SERVER_TEST_CACHE: redis
             MONGODB_VERSION: 4.4.6
             MONGODB_TOPOLOGY: standalone
             MONGODB_STORAGE_ENGINE: wiredTiger
-            NODE_VERSION: 14.17.0
+            NODE_VERSION: 14.17.1
           - name: Node 12
             MONGODB_VERSION: 4.4.6
             MONGODB_TOPOLOGY: standalone
@@ -170,16 +170,16 @@ jobs:
         include:
           - name: PostgreSQL 11, PostGIS 3.0
             POSTGRES_IMAGE: postgis/postgis:11-3.0
-            NODE_VERSION: 14.17.0
+            NODE_VERSION: 14.17.1
           - name: PostgreSQL 11, PostGIS 3.1
             POSTGRES_IMAGE: postgis/postgis:11-3.1
-            NODE_VERSION: 14.17.0
+            NODE_VERSION: 14.17.1
           - name: PostgreSQL 12, PostGIS 3.1
             POSTGRES_IMAGE: postgis/postgis:12-3.1
-            NODE_VERSION: 14.17.0
+            NODE_VERSION: 14.17.1
           - name: PostgreSQL 13, PostGIS 3.1
             POSTGRES_IMAGE: postgis/postgis:13-3.1
-            NODE_VERSION: 14.17.0
+            NODE_VERSION: 14.17.1
       fail-fast: false
     name: ${{ matrix.name }}
     timeout-minutes: 15

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -134,6 +134,7 @@ ___
 - Add NPM package-lock version check to CI (Manuel Trezza) [#7333](https://github.com/parse-community/parse-server/pull/7333)
 - Fix incorrect LiveQuery events triggered for multiple subscriptions on the same class with different events [#7341](https://github.com/parse-community/parse-server/pull/7341)
 - Fix select and excludeKey queries to properly accept JSON string arrays. Also allow nested fields in exclude (Corey Baker) [#7242](https://github.com/parse-community/parse-server/pull/7242)
+- Fix LiveQuery server crash when using $all query operator on a missing object key (Jason Posthuma) [#7421](https://github.com/parse-community/parse-server/pull/7421)
 
 ___
 ## 4.5.0

diff --git a/README.md b/README.md
@@ -115,7 +115,7 @@ Parse Server is continuously tested with the most recent releases of Node.js to
 | Version    | Latest Version | End-of-Life Date | Compatibility      |
 |------------|----------------|------------------|--------------------|
 | Node.js 12 | 12.22.1        | April 2022       | ✅ Fully compatible |
-| Node.js 14 | 14.17.0        | April 2023       | ✅ Fully compatible |
+| Node.js 14 | 14.17.1        | April 2023       | ✅ Fully compatible |
 | Node.js 15 | 15.14.0        | June 2021        | ✅ Fully compatible |
 
 #### MongoDB

diff --git a/spec/QueryTools.spec.js b/spec/QueryTools.spec.js
@@ -313,6 +313,16 @@ describe('matchesQuery', function () {
     expect(matchesQuery(player, orQuery)).toBe(true);
   });
 
+  it('does not match $all query when value is missing', () => {
+    const player = {
+      id: new Id('Player', 'P1'),
+      name: 'Player 1',
+      score: 12,
+    };
+    const q = { missing: { $all: [1, 2, 3] } };
+    expect(matchesQuery(player, q)).toBe(false);
+  });
+
   it('matches an $and query', () => {
     const player = {
       id: new Id('Player', 'P1'),

diff --git a/src/LiveQuery/QueryTools.js b/src/LiveQuery/QueryTools.js
@@ -253,6 +253,9 @@ function matchesKeyConstraints(object, key, constraints) {
         }
         break;
       case '$all':
+        if (!object[key]) {
+          return false;
+        }
         for (i = 0; i < compareTo.length; i++) {
           if (object[key].indexOf(compareTo[i]) < 0) {
             return false;