Begin to clean up JavaScript #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about switching to https://standardjs.com ? |
|
@homakov Sure, that sounds good! |
andrewda
changed the title
|
Thanks, I won't be touching codebase then for a while. |
|
Alright - I'll try to get these done as quickly as possible. |
|
Not at home so haven't tested, but all the StandardJS issues should be fixed in main.js. |
Open
|
Alright @homakov this should be good to go. Any other changes you want made? |
andrewda
changed the title
|
Awesome job @andrewda. Thanks for implementing one of my suggestions. Btw: You might want to squash your commits before merging. This helps keeping the master branch clean.
|
|
Thanks @menzow! Will squash 'em now! 👍 |
|
@menzow I squashed them into 4 different commits so it's easier to rollback an individual one if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This begins to address some of the concerns listed in #28. These are all formatting changes, nothing technical yet. From my tests everything seems to be working fine, but definitely look over this and test before merging, though, because a large part of it was automated.
When this does get merged, it will be a much more welcoming code base for new contributors.