Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Add eslint #776

Merged
merged 7 commits into from
Jun 16, 2020
Merged

Add eslint #776

merged 7 commits into from
Jun 16, 2020

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it adds eslint 🎉
Pls notice that I disabled some rules that are meant to be fixed later - it's not possible to fix all 1000 problems with one PR.

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

@lgtm-com
Copy link

lgtm-com bot commented Jun 15, 2020

This pull request introduces 1 alert and fixes 1 when merging e4fc4d5 into 4348639 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Unused or undefined state property

@lgtm-com
Copy link

lgtm-com bot commented Jun 15, 2020

This pull request introduces 1 alert and fixes 1 when merging abfae48 into 4348639 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Unused or undefined state property

@lgtm-com
Copy link

lgtm-com bot commented Jun 15, 2020

This pull request introduces 1 alert and fixes 1 when merging ee6e47a into 4348639 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Unused or undefined state property

Copy link
Member

@krzysztofwolski krzysztofwolski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix CI and can be merged

@lgtm-com
Copy link

lgtm-com bot commented Jun 16, 2020

This pull request introduces 1 alert and fixes 1 when merging 9f8b272 into a795cda - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Unused or undefined state property

@dominik-zeglen dominik-zeglen merged commit 08a018b into master Jun 16, 2020
@dominik-zeglen dominik-zeglen deleted the add/eslint branch June 16, 2020 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants