Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

SALEOR-2007 Add import sorter #979

Merged
merged 2 commits into from
Jan 14, 2021
Merged

SALEOR-2007 Add import sorter #979

merged 2 commits into from
Jan 14, 2021

Conversation

piotrgrundas
Copy link
Contributor

@piotrgrundas piotrgrundas commented Jan 11, 2021

Add eslint-plugin-simple-import-sort

Screenshots

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.rocks/graphql/

Copy link
Contributor

@jwm0 jwm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

.eslintrc Outdated Show resolved Hide resolved
@piotrgrundas piotrgrundas force-pushed the import-sort branch 2 times, most recently from 35a5057 to e73ed8c Compare January 12, 2021 20:10
@krzysztofwolski
Copy link
Member

Can we merge it after nextjs merges with master? Would like to avoid situation, where all 256 files have shuffled imports and commit message is "add next js" (we are squashing PRs)

@piotrgrundas
Copy link
Contributor Author

piotrgrundas commented Jan 13, 2021

@krzysztofwolski That's the plan 😄

Base automatically changed from feature/nextjs to master January 13, 2021 17:14
@github-actions github-actions bot temporarily deployed to import-sort January 13, 2021 17:25 Inactive
@github-actions github-actions bot temporarily deployed to storybook import-sort January 13, 2021 17:25 Inactive
@github-actions github-actions bot temporarily deployed to import-sort January 13, 2021 17:39 Inactive
@github-actions github-actions bot temporarily deployed to storybook import-sort January 13, 2021 17:39 Inactive
@piotrgrundas
Copy link
Contributor Author

piotrgrundas commented Jan 13, 2021

@jwm0 U mentioned u created some ticket for this? Could you link it with the ticket, please? 🙏

@jwm0 jwm0 changed the title Add import sorter SALEOR-2007 Add import sorter Jan 14, 2021
@patrys
Copy link
Member

patrys commented Jan 14, 2021

@piotrgrundas piotrgrundas merged commit dca8549 into master Jan 14, 2021
@piotrgrundas piotrgrundas deleted the import-sort branch January 14, 2021 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants