Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth #22

Merged
merged 7 commits into from
Sep 28, 2021
Merged

Auth #22

merged 7 commits into from
Sep 28, 2021

Conversation

krzysztofwolski
Copy link
Member

@krzysztofwolski krzysztofwolski commented Sep 27, 2021 •
edited
Loading

  • add saleor sdk
  • checkout is now created on demand
  • if user is logged in, it will use user email for the checkout
  • very basic account page
  • navigation dropdown for logged in users!
  • incremental type checking for ts speedup
  • dot file configuration

Known issues:

  • After login, please refresh browser to use auth user token. I need to find a way to recreate apollo client after the login 🤔
  • After some time auth drops session. AFAIK its connected to the server settings

@vercel
Copy link

vercel bot commented Sep 27, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/saleorcommerce/learn-saleor-demo/6LBC4hwTrMTVX6jRRCyVJq5wo7CM
✅ Preview: https://learn-saleor-demo-git-auth-saleorcommerce.vercel.app

@krzysztofwolski krzysztofwolski changed the base branch from main to categories-and-collections September 27, 2021 10:17
Base automatically changed from categories-and-collections to main September 27, 2021 11:46
@krzysztofwolski krzysztofwolski marked this pull request as ready for review September 27, 2021 16:43
@zaiste zaiste merged commit f5f0c1b into main Sep 28, 2021
@zaiste zaiste deleted the auth branch September 28, 2021 10:51
typeofweb pushed a commit that referenced this pull request Jul 27, 2022
@zaiste
Merge pull request #22 from saleor/auth
b70109b 
Auth
typeofweb pushed a commit that referenced this pull request Jul 27, 2022
@jwm0
Fix module resolution (#22)
c029624 
* Update yarn

* wip

* Change from yarn to pnpm

* Add graphql tag lib needed for types generation

* Fix checkout ci tests command

* Add checkout ci tests workflow a condition to trigger on changes in itself

* Fix checkout ci tests options passed

Co-authored-by: Magdalena Markusik <[email protected]>
@jdmueller jdmueller mentioned this pull request Jan 10, 2024
Closed
@jdmueller jdmueller mentioned this pull request Jan 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaiste zaiste zaiste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krzysztofwolski @zaiste