fix(serializer): replace LWC scope tokens (BREAKING CHANGE) #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Jun 7, 2023
| "@lwc/compiler": "^2.48.0", | ||
| "@lwc/engine-dom": "^2.48.0", | ||
| "@lwc/engine-server": "^2.48.0", | ||
| "@lwc/synthetic-shadow": "^2.48.0", |
There was a problem hiding this comment.
@lwc/compiler v2.48.0 added the cssScopeTokens return value, which we need. We might as well bump every other LWC peer dep as well, since folks shouldn't be mixing-and-matching different versions of LWC packages.
nolanlawson
force-pushed
the
nolan/scope-token
branch
2 times, most recently
from
4e3a7c0
to
ff3597f
Compare
ekashida
approved these changes
Jun 7, 2023
|
I like it! Let's do |
|
Ah, unfortunately I just realized we can't do
|
This reverts commit b80a978.
|
On second thought, how about |
|
I don't have a strong opinion but I'm leaning towards the previous version because it's self-descriptive. |
This reverts commit 7482ddc.
|
Sounds good, let's stick with the first one then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of #184
In serialized HTML, all scope tokens are replaced with
__lwc_scope_token__. This is a breaking change because it breaks all existing snapshots, and because we now require the LWCpeerDependencyof 2.48+.