Skip to content

Commit

Permalink
chore(dependabot): ignore prettier v3 (#4387)
Browse files Browse the repository at this point in the history
* chore(dependabot): ignore prettier v3

* chore(prettier): prepare for v3

use v2 value for trailingComma

add note to places that will need updates

* chore(dependabot): add issue number for prettier TODO
  • Loading branch information
wjhsf authored Jul 16, 2024
1 parent 1733916 commit 41091d2
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,8 @@ updates:
# We are pinned to Tachometer 0.5.10 due to a breaking change in 0.6.0.
# See: https://github.com/google/tachometer/issues/244
- dependency-name: 'tachometer'
# TODO [#4386]: Stop ignoring when we've done the upgrade ourselves
- dependency-name: 'prettier'
versions: '>= 3'
- dependency-name: '@types/prettier'
versions: '>= 3'
3 changes: 2 additions & 1 deletion .prettierrc
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"printWidth": 100,
"singleQuote": true,
"tabWidth": 4
"tabWidth": 4,
"trailingComma": "es5"
}
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ describe('fixtures', () => {
);

return {
// TODO [#4386]: Prettier v3 returns a promise - add an `await` here
'expected.js': prettier.format(code, { parser: 'babel' }),
'ast.json': JSON.stringify({ root }, null, 4),
'metadata.json': JSON.stringify({ warnings }, null, 4),
Expand Down
1 change: 1 addition & 0 deletions scripts/tasks/generate-license-files.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ async function main() {
'\n'
)}`.trim() + '\n';

// TODO [#4386]: Prettier v3 returns a promise - add an `await` here
const formattedLicense = prettier.format(newLicense, {
parser: 'markdown',
});
Expand Down

0 comments on commit 41091d2

Please sign in to comment.