fix: remove assert due to safari bug (#798)

* fix: remove assert due to safari bug * fix: bump peer dependencies * fix: lint issue
salesforce · Nov 2, 2018 · 9381315 · 9381315
1 parent 7076bd9
commit 9381315
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/packages/lwc-engine/src/framework/def.ts b/packages/lwc-engine/src/framework/def.ts
@@ -13,13 +13,11 @@ import {
     freeze,
     create,
     ArrayIndexOf,
-    toString,
     ArrayPush,
     defineProperty,
     getOwnPropertyDescriptor,
     getOwnPropertyNames,
     getPrototypeOf,
-    isString,
     isFunction,
     isNull,
     setPrototypeOf,
@@ -127,7 +125,8 @@ function createComponentDef(Ctor: ComponentConstructor): ComponentDef {
 
         // local to dev block
         const ctorName = Ctor.name;
-        assert.isTrue(ctorName && isString(ctorName), `${toString(Ctor)} should have a "name" property with string value, but found ${ctorName}.`);
+        // Removing the following assert until https://bugs.webkit.org/show_bug.cgi?id=190140 is fixed.
+        // assert.isTrue(ctorName && isString(ctorName), `${toString(Ctor)} should have a "name" property with string value, but found ${ctorName}.`);
         assert.isTrue(Ctor.constructor, `Missing ${ctorName}.constructor, ${ctorName} should have a "constructor" property.`);
     }
 

diff --git a/packages/lwc-jest-transformer/package.json b/packages/lwc-jest-transformer/package.json
@@ -17,9 +17,9 @@
     "deasync": "0.1.12"
   },
   "peerDependencies": {
-    "lwc-compiler": "0.30.x",
-    "lwc-engine": "0.30.x",
-    "lwc-errors": "0.30.x"
+    "lwc-compiler": "0.31.x",
+    "lwc-engine": "0.31.x",
+    "lwc-errors": "0.31.x"
   },
   "devDependencies": {
     "lwc-compiler": "0.31.1",

diff --git a/packages/rollup-plugin-lwc-compiler/package.json b/packages/rollup-plugin-lwc-compiler/package.json
@@ -17,7 +17,7 @@
     "rollup-pluginutils": "^2.0.1"
   },
   "peerDependencies": {
-    "lwc-compiler": "0.30.x",
-    "lwc-engine": "0.30.x"
+    "lwc-compiler": "0.31.x",
+    "lwc-engine": "0.31.x"
   }
 }