refactor(engine-core): Remove unnecessary props/attrs assertions (#2639)

salesforce · Jan 14, 2022 · c7833d3 · c7833d3
1 parent 17dc495
commit c7833d3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 16 deletions.
diff --git a/packages/@lwc/engine-core/src/framework/modules/attrs.ts b/packages/@lwc/engine-core/src/framework/modules/attrs.ts
@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: MIT
  * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
  */
-import { assert, isNull, isUndefined, keys, StringCharCodeAt } from '@lwc/shared';
+import { isNull, isUndefined, StringCharCodeAt } from '@lwc/shared';
 
 import { setAttribute, removeAttribute } from '../../renderer';
 import { VElement } from '../../3rdparty/snabbdom/types';
@@ -27,13 +27,6 @@ export function patchAttributes(oldVnode: VElement | null, vnode: VElement) {
         return;
     }
 
-    if (process.env.NODE_ENV !== 'production') {
-        assert.invariant(
-            oldAttrs === EmptyObject || keys(oldAttrs).join(',') === keys(attrs).join(','),
-            `vnode.data.attrs cannot change shape.`
-        );
-    }
-
     const { elm } = vnode;
     for (const key in attrs) {
         const cur = attrs[key];

diff --git a/packages/@lwc/engine-core/src/framework/modules/props.ts b/packages/@lwc/engine-core/src/framework/modules/props.ts
@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: MIT
  * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
  */
-import { assert, isNull, isUndefined, keys } from '@lwc/shared';
+import { isNull, isUndefined } from '@lwc/shared';
 
 import { getProperty, setProperty } from '../../renderer';
 import { VElement } from '../../3rdparty/snabbdom/types';
@@ -28,13 +28,6 @@ export function patchProps(oldVnode: VElement | null, vnode: VElement) {
         return;
     }
 
-    if (process.env.NODE_ENV !== 'production') {
-        assert.invariant(
-            oldProps === EmptyObject || keys(oldProps).join(',') === keys(props).join(','),
-            'vnode.data.props cannot change shape.'
-        );
-    }
-
     const isFirstPatch = isNull(oldVnode);
     const { elm, sel } = vnode;