Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): fixes issue #972 - getRootNode on shadows #1002

Merged
merged 2 commits into from
Jan 28, 2019

Conversation

caridy
Copy link
Contributor

@caridy caridy commented Jan 22, 2019

bugfix for #972

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 87d211c | Target commit: 597ec28

lwc-engine-benchmark

table-append-1k metric base(87d211c) target(597ec28) trend
benchmark-table/append/1k duration 149.35 (±5.05 ms) 148.00 (±4.20 ms) -1.3ms (0.9%) 👌
table-clear-1k metric base(87d211c) target(597ec28) trend
benchmark-table/clear/1k duration 5.80 (±0.50 ms) 5.80 (±0.45 ms) 0.0ms (0.0%) 👌
table-create-10k metric base(87d211c) target(597ec28) trend
benchmark-table/create/10k duration 898.30 (±5.10 ms) 882.60 (±5.80 ms) -15.7ms (1.7%) 👍
table-create-1k metric base(87d211c) target(597ec28) trend
benchmark-table/create/1k duration 116.25 (±3.05 ms) 117.35 (±2.25 ms) +1.1ms (0.9%) 👌
table-update-10th-1k metric base(87d211c) target(597ec28) trend
benchmark-table/update-10th/1k duration 76.15 (±5.15 ms) 84.30 (±3.25 ms) +8.2ms (10.7%) 👌
tablecmp-append-1k metric base(87d211c) target(597ec28) trend
benchmark-table-component/append/1k duration 215.30 (±10.70 ms) 217.35 (±8.25 ms) +2.0ms (1.0%) 👌
tablecmp-clear-1k metric base(87d211c) target(597ec28) trend
benchmark-table-component/clear/1k duration 12.45 (±1.40 ms) 11.85 (±1.55 ms) -0.6ms (4.8%) 👌
tablecmp-create-10k metric base(87d211c) target(597ec28) trend
benchmark-table-component/create/10k duration 1739.35 (±13.10 ms) 1719.40 (±12.35 ms) -19.9ms (1.1%) 👍
tablecmp-create-1k metric base(87d211c) target(597ec28) trend
benchmark-table-component/create/1k duration 206.55 (±5.80 ms) 210.15 (±7.90 ms) +3.6ms (1.7%) 👌
tablecmp-update-10th-1k metric base(87d211c) target(597ec28) trend
benchmark-table-component/update-10th/1k duration 69.80 (±4.85 ms) 69.15 (±4.50 ms) -0.6ms (0.9%) 👌
wc-append-1k metric base(87d211c) target(597ec28) trend
benchmark-table-wc/append/1k duration 253.45 (±5.45 ms) 254.55 (±4.75 ms) +1.1ms (0.4%) 👌
wc-clear-1k metric base(87d211c) target(597ec28) trend
benchmark-table-wc/clear/1k duration 22.60 (±2.10 ms) 21.45 (±2.35 ms) -1.2ms (5.1%) 👍
wc-create-10k metric base(87d211c) target(597ec28) trend
benchmark-table-wc/create/10k duration 1947.40 (±13.95 ms) 1985.75 (±10.85 ms) +38.3ms (2.0%) 👎
wc-create-1k metric base(87d211c) target(597ec28) trend
benchmark-table-wc/create/1k duration 224.25 (±4.70 ms) 219.85 (±5.95 ms) -4.4ms (2.0%) 👍
wc-update-10th-1k metric base(87d211c) target(597ec28) trend
benchmark-table-wc/update-10th/1k duration 69.10 (±5.50 ms) 70.35 (±6.10 ms) +1.3ms (1.8%) 👌

@caridy caridy merged commit bd77365 into master Jan 28, 2019
@caridy caridy deleted the caridy/issue-987/220 branch January 28, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants