Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine): fixes issue #972 - getRootNode on shadows #1002

Merged
merged 2 commits into from
Jan 28, 2019
Merged

fix(engine): fixes issue #972 - getRootNode on shadows #1002

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d70264
fix(engine): fixes issue #972 - getRootNode on shadows
caridy Jan 22, 2019
597ec28
fix(engine): PR #1002 more
caridy Jan 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/@lwc/engine/src/faux-shadow/shadow-root.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
*/
import assert from "../shared/assert";
import { assign, create, isNull, setPrototypeOf, defineProperty, ArrayFilter, defineProperties, isUndefined } from "../shared/language";
import { assign, create, isNull, setPrototypeOf, defineProperty, ArrayFilter, defineProperties, isUndefined, isFalse } from "../shared/language";
import { addShadowRootEventListener, removeShadowRootEventListener } from "./events";
import { shadowRootQuerySelector, shadowRootQuerySelectorAll, shadowRootChildNodes, isNodeOwnedBy, isSlotElement, getRootNodeGetter } from "./traverse";
import { getInternalField, setInternalField, createFieldName } from "../shared/fields";
Expand Down Expand Up @@ -376,7 +376,8 @@ const NodePatchDescriptors = {
enumerable: true,
configurable: true,
value(this: SyntheticShadowRootInterface, options?: GetRootNodeOptions): Node {
return getRootNodeGetter.call(this, options);
const composed: boolean = isUndefined(options) ? false : !!options.composed;
return isFalse(composed) ? this : getRootNodeGetter.call(getHost(this), { composed });
},
},
};
Expand Down