Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[engine] document.activeElement should be patched on document.prototype #1304

Closed
ekashida opened this issue May 28, 2019 · 0 comments
Closed

[engine] document.activeElement should be patched on document.prototype #1304

ekashida opened this issue May 28, 2019 · 0 comments

Comments

@ekashida
Copy link
Member

lwc/packages/@lwc/synthetic-shadow/src/polyfills/document-shadow/polyfill.ts

Line 59 in 37f8cf2

// TODO: this should be patched on Document.prototype instead

jodarove added a commit that referenced this issue May 30, 2019
@jodarove
fix: issue #1304 activeElement should be patched in the prototype
f8122ea
@jodarove jodarove mentioned this issue May 30, 2019
Merged
jodarove added a commit that referenced this issue May 31, 2019
@jodarove
fix: issue #1304 activeElement should be patched in the prototype (#1321
504e27a 
)

* fix: issue #1304 activeElement should be patched in the prototype

* fix: remove todo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ekashida @ravijayaramappa