Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nested style fix #1378

Merged
merged 1 commit into from
Jun 25, 2019
Merged

fix: nested style fix #1378

merged 1 commit into from
Jun 25, 2019

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Jun 25, 2019

Details

Fixes #1376

Does this PR introduce breaking changes?

  • No, it does not introduce breaking changes.

@diervo diervo requested a review from pmdartus June 25, 2019 17:50
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 4395c22 | Target commit: 97f5831

lwc-engine-benchmark

table-append-1k metric base(4395c22) target(97f5831) trend
benchmark-table/append/1k duration 145.60 (±5.65 ms) 146.60 (±4.00 ms) +1.0ms (0.7%) 👌
table-clear-1k metric base(4395c22) target(97f5831) trend
benchmark-table/clear/1k duration 10.60 (±0.90 ms) 11.20 (±0.95 ms) +0.6ms (5.7%) 👌
table-create-10k metric base(4395c22) target(97f5831) trend
benchmark-table/create/10k duration 860.65 (±6.90 ms) 868.90 (±6.15 ms) +8.3ms (1.0%) 👎
table-create-1k metric base(4395c22) target(97f5831) trend
benchmark-table/create/1k duration 109.45 (±2.90 ms) 108.25 (±2.35 ms) -1.2ms (1.1%) 👌
table-update-10th-1k metric base(4395c22) target(97f5831) trend
benchmark-table/update-10th/1k duration 69.70 (±1.80 ms) 69.35 (±1.75 ms) -0.3ms (0.5%) 👌
tablecmp-append-1k metric base(4395c22) target(97f5831) trend
benchmark-table-component/append/1k duration 215.50 (±14.80 ms) 225.05 (±13.10 ms) +9.6ms (4.4%) 👌
tablecmp-clear-1k metric base(4395c22) target(97f5831) trend
benchmark-table-component/clear/1k duration 7.60 (±1.50 ms) 7.30 (±1.25 ms) -0.3ms (3.9%) 👌
tablecmp-create-10k metric base(4395c22) target(97f5831) trend
benchmark-table-component/create/10k duration 1618.10 (±8.70 ms) 1635.10 (±9.60 ms) +17.0ms (1.1%) 👎
tablecmp-create-1k metric base(4395c22) target(97f5831) trend
benchmark-table-component/create/1k duration 188.55 (±4.10 ms) 184.05 (±3.60 ms) -4.5ms (2.4%) 👍
tablecmp-update-10th-1k metric base(4395c22) target(97f5831) trend
benchmark-table-component/update-10th/1k duration 71.55 (±5.25 ms) 70.85 (±7.55 ms) -0.7ms (1.0%) 👌
wc-append-1k metric base(4395c22) target(97f5831) trend
benchmark-table-wc/append/1k duration 232.45 (±14.80 ms) 227.95 (±9.35 ms) -4.5ms (1.9%) 👌
wc-clear-1k metric base(4395c22) target(97f5831) trend
benchmark-table-wc/clear/1k duration 12.70 (±1.50 ms) 12.65 (±1.45 ms) -0.1ms (0.4%) 👌
wc-create-10k metric base(4395c22) target(97f5831) trend
benchmark-table-wc/create/10k duration 1904.95 (±12.90 ms) 1863.95 (±12.95 ms) -41.0ms (2.2%) 👍
wc-create-1k metric base(4395c22) target(97f5831) trend
benchmark-table-wc/create/1k duration 223.20 (±5.55 ms) 222.95 (±6.10 ms) -0.3ms (0.1%) 👌
wc-update-10th-1k metric base(4395c22) target(97f5831) trend
benchmark-table-wc/update-10th/1k duration 67.00 (±4.65 ms) 68.05 (±4.20 ms) +1.0ms (1.6%) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 4395c22 | Target commit: 97f5831

lwc-engine-benchmark

table-append-1k metric base(4395c22) target(97f5831) trend
benchmark-table/append/1k duration 145.60 (±5.65 ms) 146.65 (±5.25 ms) +1.0ms (0.7%) 👌
table-clear-1k metric base(4395c22) target(97f5831) trend
benchmark-table/clear/1k duration 10.60 (±0.90 ms) 10.60 (±0.75 ms) 0.0ms (0.0%) 👌
table-create-10k metric base(4395c22) target(97f5831) trend
benchmark-table/create/10k duration 860.65 (±6.90 ms) 861.80 (±6.10 ms) +1.1ms (0.1%) 👌
table-create-1k metric base(4395c22) target(97f5831) trend
benchmark-table/create/1k duration 109.45 (±2.90 ms) 108.10 (±2.85 ms) -1.3ms (1.2%) 👌
table-update-10th-1k metric base(4395c22) target(97f5831) trend
benchmark-table/update-10th/1k duration 69.70 (±1.80 ms) 78.90 (±3.35 ms) +9.2ms (13.2%) 👎
tablecmp-append-1k metric base(4395c22) target(97f5831) trend
benchmark-table-component/append/1k duration 215.50 (±14.80 ms) 220.05 (±16.35 ms) +4.6ms (2.1%) 👌
tablecmp-clear-1k metric base(4395c22) target(97f5831) trend
benchmark-table-component/clear/1k duration 7.60 (±1.50 ms) 7.30 (±1.30 ms) -0.3ms (3.9%) 👌
tablecmp-create-10k metric base(4395c22) target(97f5831) trend
benchmark-table-component/create/10k duration 1618.10 (±8.70 ms) 1611.80 (±12.45 ms) -6.3ms (0.4%) 👍
tablecmp-create-1k metric base(4395c22) target(97f5831) trend
benchmark-table-component/create/1k duration 188.55 (±4.10 ms) 188.65 (±3.55 ms) +0.1ms (0.1%) 👌
tablecmp-update-10th-1k metric base(4395c22) target(97f5831) trend
benchmark-table-component/update-10th/1k duration 71.55 (±5.25 ms) 68.05 (±6.80 ms) -3.5ms (4.9%) 👍
wc-append-1k metric base(4395c22) target(97f5831) trend
benchmark-table-wc/append/1k duration 232.45 (±14.80 ms) 234.95 (±8.90 ms) +2.5ms (1.1%) 👌
wc-clear-1k metric base(4395c22) target(97f5831) trend
benchmark-table-wc/clear/1k duration 12.70 (±1.50 ms) 12.10 (±1.60 ms) -0.6ms (4.7%) 👌
wc-create-10k metric base(4395c22) target(97f5831) trend
benchmark-table-wc/create/10k duration 1904.95 (±12.90 ms) 1876.80 (±8.85 ms) -28.1ms (1.5%) 👍
wc-create-1k metric base(4395c22) target(97f5831) trend
benchmark-table-wc/create/1k duration 223.20 (±5.55 ms) 223.90 (±3.55 ms) +0.7ms (0.3%) 👌
wc-update-10th-1k metric base(4395c22) target(97f5831) trend
benchmark-table-wc/update-10th/1k duration 67.00 (±4.65 ms) 70.75 (±4.15 ms) +3.8ms (5.6%) 👎

Copy link
Member

@ekashida ekashida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jonnyl
Copy link

jonnyl commented Jun 25, 2019

Nicely done, @diervo!

@diervo diervo merged commit 1cdc92e into master Jun 25, 2019
@diervo diervo deleted the dval/cssVarFix branch June 25, 2019 23:41
diervo pushed a commit that referenced this pull request Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style compiler fails on COMPAT for nested var combined expressions
3 participants