feat(compiler): raptor on platform #298

apapko · 2018-05-11T22:49:16Z

Details

This PR includes several enhancements to the open source compiler to allow for source code diagnostics and cleaner integration with platform compiler. The open source compiler will be consumed by platform-compiler for transformation and bundling invocation. Furthermore, as part of the effort to minimize compiler maintenance and code/feature duplication, platform-compiler, which in-itself consumes open source compiler, will be now used by both Aura open source and core in the form of a jar ( maven dependency ).

Some details on the changes:

Types: everything in the compiler is typed now.
Feature based folder structure refactoring
More tests coverage
Compiler Interface changes
Diagnostics

Few remaining TODOS:

figure out how to expose all compiler types
regenerate expected results in 'amd' format for older tests

Does this PR introduce a breaking change?

Yes
No
Compiler interface has changed. Aura will now be using platform compiler instead - thus invocation API must be change in Aura to satisfy platform compiler interface - tracked separately.

* wip: module import locations * wip: move import locations into metadata * wip: rename import locations * wip: use common location class in import locations * wip: change regex and token retrieval

* feat(compiler): use real compiler version during build

* fix(compiler): module resolver fails to import custom template

salesforce-best-lwc-internal · 2018-05-11T23:01:32Z

Benchmark results

Base commit: fde372d | Target commit: ac7d0a3

lwc-engine-benchmark

table-append-1k	metric	base(`fde372d`)	target(`ac7d0a3`)	trend
benchmark-table/append/1k	duration	144.30 (± 4.40 ms)	143.90 (± 3.40 ms)	0.28% 👌

table-clear-1k	metric	base(`fde372d`)	target(`ac7d0a3`)	trend
benchmark-table/clear/1k	duration	11.70 (± 0.50 ms)	11.80 (± 0.50 ms)	-0.85% 👌

table-create-10k	metric	base(`fde372d`)	target(`ac7d0a3`)	trend
benchmark-table/create/10k	duration	855.00 (± 4.50 ms)	850.90 (± 3.80 ms)	0.48% 👍

table-create-1k	metric	base(`fde372d`)	target(`ac7d0a3`)	trend
benchmark-table/create/1k	duration	100.80 (± 1.90 ms)	101.95 (± 1.60 ms)	-1.14% 👌

table-update-10th-1k	metric	base(`fde372d`)	target(`ac7d0a3`)	trend
benchmark-table/update-10th/1k	duration	86.00 (± 5.00 ms)	92.35 (± 5.15 ms)	-7.38% 👎

tablecmp-append-1k	metric	base(`fde372d`)	target(`ac7d0a3`)	trend
benchmark-table-component/append/1k	duration	246.10 (± 5.20 ms)	248.20 (± 5.40 ms)	-0.85% 👌

tablecmp-clear-1k	metric	base(`fde372d`)	target(`ac7d0a3`)	trend
benchmark-table/clear/1k	duration	31.40 (± 1.30 ms)	31.90 (± 1.80 ms)	-1.59% 👌

tablecmp-create-10k	metric	base(`fde372d`)	target(`ac7d0a3`)	trend
benchmark-table-component/create/10k	duration	1678.50 (± 11.20 ms)	1692.40 (± 8.90 ms)	-0.83% 👎

tablecmp-create-1k	metric	base(`fde372d`)	target(`ac7d0a3`)	trend
benchmark-table-component/create/1k	duration	194.40 (± 3.10 ms)	195.60 (± 3.20 ms)	-0.62% 👌

tablecmp-update-10th-1k	metric	base(`fde372d`)	target(`ac7d0a3`)	trend
benchmark-table-component/update-10th/1k	duration	74.80 (± 4.30 ms)	76.40 (± 4.00 ms)	-2.14% 👌

salesforce-best-lwc-internal · 2018-05-14T16:53:03Z

Benchmark results

Base commit: 75722cb | Target commit: f9f23f8

lwc-engine-benchmark

table-append-1k	metric	base(`75722cb`)	target(`f9f23f8`)	trend
benchmark-table/append/1k	duration	142.90 (± 2.40 ms)	143.30 (± 3.80 ms)	-0.28% 👌

table-clear-1k	metric	base(`75722cb`)	target(`f9f23f8`)	trend
benchmark-table/clear/1k	duration	11.40 (± 0.40 ms)	11.30 (± 0.40 ms)	0.88% 👌

table-create-10k	metric	base(`75722cb`)	target(`f9f23f8`)	trend
benchmark-table/create/10k	duration	849.10 (± 7.70 ms)	853.00 (± 6.20 ms)	-0.46% 👎

table-create-1k	metric	base(`75722cb`)	target(`f9f23f8`)	trend
benchmark-table/create/1k	duration	101.00 (± 2.30 ms)	102.30 (± 1.70 ms)	-1.29% 👌

table-update-10th-1k	metric	base(`75722cb`)	target(`f9f23f8`)	trend
benchmark-table/update-10th/1k	duration	95.00 (± 4.60 ms)	92.00 (± 4.70 ms)	3.16% 👌

tablecmp-append-1k	metric	base(`75722cb`)	target(`f9f23f8`)	trend
benchmark-table-component/append/1k	duration	243.40 (± 5.40 ms)	247.10 (± 5.10 ms)	-1.52% 👎

tablecmp-clear-1k	metric	base(`75722cb`)	target(`f9f23f8`)	trend
benchmark-table/clear/1k	duration	31.60 (± 1.10 ms)	31.10 (± 1.40 ms)	1.58% 👌

tablecmp-create-10k	metric	base(`75722cb`)	target(`f9f23f8`)	trend
benchmark-table-component/create/10k	duration	1717.10 (± 9.00 ms)	1678.20 (± 10.00 ms)	2.27% 👍

tablecmp-create-1k	metric	base(`75722cb`)	target(`f9f23f8`)	trend
benchmark-table-component/create/1k	duration	193.60 (± 3.80 ms)	192.80 (± 3.20 ms)	0.41% 👌

tablecmp-update-10th-1k	metric	base(`75722cb`)	target(`f9f23f8`)	trend
benchmark-table-component/update-10th/1k	duration	74.10 (± 3.80 ms)	76.30 (± 4.80 ms)	-2.97% 👌

apapko · 2018-05-14T16:59:28Z

@byao @diervo compiler PR is up to date. We need to agree if this change is going into master before renaming PR and start merging

salesforce-best-lwc-internal · 2018-05-17T22:24:53Z

Benchmark results

Base commit: 6ad80ca | Target commit: 5a17ab5

salesforce-best-lwc-internal · 2018-05-17T22:26:45Z

Benchmark results

Base commit: 6ad80ca | Target commit: 5a17ab5

salesforce-best-lwc-internal · 2018-05-18T22:58:34Z

Benchmark results

Base commit: 6ad80ca | Target commit: 6613936

lwc-engine-benchmark

table-append-1k	metric	base(`6ad80ca`)	target(`6613936`)	trend
benchmark-table/append/1k	duration	151.80 (± 6.00 ms)	144.55 (± 3.70 ms)	4.78% 👍

table-clear-1k	metric	base(`6ad80ca`)	target(`6613936`)	trend
benchmark-table/clear/1k	duration	11.90 (± 0.50 ms)	11.50 (± 0.50 ms)	3.36% 👌

table-create-10k	metric	base(`6ad80ca`)	target(`6613936`)	trend
benchmark-table/create/10k	duration	843.60 (± 6.50 ms)	841.10 (± 5.10 ms)	0.30% 👌

table-create-1k	metric	base(`6ad80ca`)	target(`6613936`)	trend
benchmark-table/create/1k	duration	102.60 (± 1.50 ms)	101.30 (± 1.70 ms)	1.27% 👍

table-update-10th-1k	metric	base(`6ad80ca`)	target(`6613936`)	trend
benchmark-table/update-10th/1k	duration	90.35 (± 5.55 ms)	91.90 (± 4.20 ms)	-1.72% 👌

tablecmp-append-1k	metric	base(`6ad80ca`)	target(`6613936`)	trend
benchmark-table-component/append/1k	duration	213.10 (± 14.50 ms)	244.90 (± 4.30 ms)	-14.92% 👎

tablecmp-clear-1k	metric	base(`6ad80ca`)	target(`6613936`)	trend
benchmark-table/clear/1k	duration	31.90 (± 1.40 ms)	31.90 (± 1.00 ms)	0.00% 👌

tablecmp-create-10k	metric	base(`6ad80ca`)	target(`6613936`)	trend
benchmark-table-component/create/10k	duration	1701.20 (± 11.20 ms)	1697.10 (± 9.00 ms)	0.24% 👌

tablecmp-create-1k	metric	base(`6ad80ca`)	target(`6613936`)	trend
benchmark-table-component/create/1k	duration	192.90 (± 4.10 ms)	196.75 (± 4.50 ms)	-2.00% 👎

tablecmp-update-10th-1k	metric	base(`6ad80ca`)	target(`6613936`)	trend
benchmark-table-component/update-10th/1k	duration	77.50 (± 4.70 ms)	75.20 (± 3.90 ms)	2.97% 👌

* wip: merge master * refactor(compiler): add proper type to css transformer

salesforce-best-lwc-internal · 2018-05-19T19:13:00Z

Benchmark results

Base commit: 6ad3b7c | Target commit: bffafe1

lwc-engine-benchmark

table-append-1k	metric	base(`6ad3b7c`)	target(`bffafe1`)	trend
benchmark-table/append/1k	duration	145.90 (± 3.70 ms)	146.70 (± 4.50 ms)	-0.55% 👌

table-clear-1k	metric	base(`6ad3b7c`)	target(`bffafe1`)	trend
benchmark-table/clear/1k	duration	11.70 (± 0.40 ms)	11.70 (± 0.50 ms)	0.00% 👌

table-create-10k	metric	base(`6ad3b7c`)	target(`bffafe1`)	trend
benchmark-table/create/10k	duration	855.90 (± 11.40 ms)	851.15 (± 6.25 ms)	0.55% 👍

table-create-1k	metric	base(`6ad3b7c`)	target(`bffafe1`)	trend
benchmark-table/create/1k	duration	102.20 (± 1.20 ms)	100.45 (± 2.05 ms)	1.71% 👍

table-update-10th-1k	metric	base(`6ad3b7c`)	target(`bffafe1`)	trend
benchmark-table/update-10th/1k	duration	86.70 (± 4.50 ms)	87.40 (± 4.40 ms)	-0.81% 👌

tablecmp-append-1k	metric	base(`6ad3b7c`)	target(`bffafe1`)	trend
benchmark-table-component/append/1k	duration	246.80 (± 4.70 ms)	245.30 (± 5.30 ms)	0.61% 👌

tablecmp-clear-1k	metric	base(`6ad3b7c`)	target(`bffafe1`)	trend
benchmark-table/clear/1k	duration	31.80 (± 1.10 ms)	33.10 (± 1.30 ms)	-4.09% 👎

tablecmp-create-10k	metric	base(`6ad3b7c`)	target(`bffafe1`)	trend
benchmark-table-component/create/10k	duration	1706.70 (± 14.20 ms)	1680.80 (± 7.40 ms)	1.52% 👍

tablecmp-create-1k	metric	base(`6ad3b7c`)	target(`bffafe1`)	trend
benchmark-table-component/create/1k	duration	190.90 (± 3.00 ms)	190.50 (± 4.30 ms)	0.21% 👌

tablecmp-update-10th-1k	metric	base(`6ad3b7c`)	target(`bffafe1`)	trend
benchmark-table-component/update-10th/1k	duration	75.80 (± 4.20 ms)	73.10 (± 4.40 ms)	3.56% 👌

salesforce-best-lwc-internal · 2018-05-19T19:33:15Z

Benchmark results

Base commit: 6ad3b7c | Target commit: 905ef3f

lwc-engine-benchmark

table-append-1k	metric	base(`6ad3b7c`)	target(`905ef3f`)	trend
benchmark-table/append/1k	duration	145.90 (± 3.70 ms)	145.60 (± 4.40 ms)	0.21% 👌

table-clear-1k	metric	base(`6ad3b7c`)	target(`905ef3f`)	trend
benchmark-table/clear/1k	duration	11.70 (± 0.40 ms)	11.80 (± 0.55 ms)	-0.85% 👌

table-create-10k	metric	base(`6ad3b7c`)	target(`905ef3f`)	trend
benchmark-table/create/10k	duration	855.90 (± 11.40 ms)	842.90 (± 10.10 ms)	1.52% 👍

table-create-1k	metric	base(`6ad3b7c`)	target(`905ef3f`)	trend
benchmark-table/create/1k	duration	102.20 (± 1.20 ms)	100.70 (± 2.00 ms)	1.47% 👍

table-update-10th-1k	metric	base(`6ad3b7c`)	target(`905ef3f`)	trend
benchmark-table/update-10th/1k	duration	86.70 (± 4.50 ms)	92.00 (± 5.00 ms)	-6.11% 👌

tablecmp-append-1k	metric	base(`6ad3b7c`)	target(`905ef3f`)	trend
benchmark-table-component/append/1k	duration	246.80 (± 4.70 ms)	245.80 (± 3.70 ms)	0.41% 👌

tablecmp-clear-1k	metric	base(`6ad3b7c`)	target(`905ef3f`)	trend
benchmark-table/clear/1k	duration	31.80 (± 1.10 ms)	31.10 (± 1.40 ms)	2.20% 👌

tablecmp-create-10k	metric	base(`6ad3b7c`)	target(`905ef3f`)	trend
benchmark-table-component/create/10k	duration	1706.70 (± 14.20 ms)	1680.60 (± 6.10 ms)	1.53% 👍

tablecmp-create-1k	metric	base(`6ad3b7c`)	target(`905ef3f`)	trend
benchmark-table-component/create/1k	duration	190.90 (± 3.00 ms)	186.80 (± 4.00 ms)	2.15% 👍

tablecmp-update-10th-1k	metric	base(`6ad3b7c`)	target(`905ef3f`)	trend
benchmark-table-component/update-10th/1k	duration	75.80 (± 4.20 ms)	72.00 (± 5.20 ms)	5.01% 👌

ravijayaramappa · 2018-06-01T15:50:45Z

packages/lwc-compiler/package.json

  "author": "",
  "license": "ISC",
  "scripts": {
    "clean": "rm -rf dist",
-    "build": "echo 'Building compiler...' && DIR=`pwd` && cd ../../ && tsc -p $DIR/tsconfig.json",
-    "build:all": "",
-    "build:umd": "webpack --progress",


@apapko removing build:umd breaks yarn build:compiler script in the base package.json https://github.com/salesforce/lwc/blob/master/package.json#L15

apapko added 30 commits March 5, 2018 14:38

wip: merge master with compiler

b235149

wip: remove transform bundle export from compiler

6258e82

wip: remove transform and cleanup

7c52e15

wip: remove unsused variables

8c2a302

wip: lint fixes

580cc75

wip: first set of review comments

abf1d32

wip: expose compiler types

e9d2c99

wip: create local meta type and remove empty interface

a091c1f

wip: review comments

4463231

wip: review comments

7177fa1

wip: revert dynamic version change

d641c35

wip: rename all reference getters to reports

fe3717c

feat(compiler): compiler returns import locations (#139)

61c93d0

* wip: module import locations * wip: move import locations into metadata * wip: rename import locations * wip: use common location class in import locations * wip: change regex and token retrieval

wip: reference report includes module imports

94d3c61

feat(compiler): return compiler version

8658969

refactor(compiler): remove reference gathering logic

5dc1807

wip: fix lint errors

e01fd79

feat(compiler): compiler returns output config

41e22ad

wip: remove unused imports

1477aa3

fix(compiler): fix output config mergge

fe4ef3f

wip: merge with master and correct compat

081a6a1

wip: cleanup

1e9e087

feat(compiler): use real compiler version during build (#267)

06c87c4

* feat(compiler): use real compiler version during build

wip: first set of review fixes

b004f3c

wip: review comments + test breakup

6d0a34f

wip: lint changes

3efd4fa

wip: merge master

99b3d57

fix(test): remove unnecessary exception count

b8792c0

fix(test): fix modes fixture path

ba50615

fix(compiler): module-resolver supports custom template (#291)

7cbb9d8

* fix(compiler): module resolver fails to import custom template

wip(compiler): merge master

ac7d0a3

apapko requested a review from diervo May 11, 2018 22:49

Merge branch 'master' into apapko/raptor-on-platform-compiler

f9f23f8

test(compiler): add nested folder test

5a17ab5

test(compiler): nested folder test

6613936

fix(compiler): merge master with new template style injection (#319)

bffafe1

* wip: merge master * refactor(compiler): add proper type to css transformer

apapko added 2 commits May 19, 2018 12:15

wip: remove left over files

152730c

wip: remove deleted file

905ef3f

diervo merged commit 922de78 into master May 28, 2018

diervo deleted the apapko/raptor-on-platform-compiler branch May 28, 2018 19:04

ravijayaramappa reviewed Jun 1, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(compiler): raptor on platform #298

feat(compiler): raptor on platform #298

apapko commented May 11, 2018

salesforce-best-lwc-internal bot commented May 11, 2018

salesforce-best-lwc-internal bot commented May 14, 2018

apapko commented May 14, 2018

salesforce-best-lwc-internal bot commented May 17, 2018

salesforce-best-lwc-internal bot commented May 17, 2018

salesforce-best-lwc-internal bot commented May 18, 2018

salesforce-best-lwc-internal bot commented May 19, 2018

salesforce-best-lwc-internal bot commented May 19, 2018

ravijayaramappa Jun 1, 2018

feat(compiler): raptor on platform #298

feat(compiler): raptor on platform #298

Conversation

apapko commented May 11, 2018

Details

Does this PR introduce a breaking change?

salesforce-best-lwc-internal bot commented May 11, 2018

Benchmark results

lwc-engine-benchmark

salesforce-best-lwc-internal bot commented May 14, 2018

Benchmark results

lwc-engine-benchmark

apapko commented May 14, 2018

salesforce-best-lwc-internal bot commented May 17, 2018

Benchmark results

salesforce-best-lwc-internal bot commented May 17, 2018

Benchmark results

salesforce-best-lwc-internal bot commented May 18, 2018

Benchmark results

lwc-engine-benchmark

salesforce-best-lwc-internal bot commented May 19, 2018

Benchmark results

lwc-engine-benchmark

salesforce-best-lwc-internal bot commented May 19, 2018

Benchmark results

lwc-engine-benchmark

ravijayaramappa Jun 1, 2018

Choose a reason for hiding this comment