Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): merge master with new template style injection #319

Merged
merged 3 commits into from
May 19, 2018

Conversation

apapko
Copy link
Collaborator

@apapko apapko commented May 19, 2018

Details

Don't merge, this is a test

Does this PR introduce a breaking change?

  • Yes
  • No

@apapko apapko added the nomerge label May 19, 2018
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 6ad3b7c | Target commit: b493418

lwc-engine-benchmark

table-append-1k metric base(6ad3b7c) target(b493418) trend
benchmark-table/append/1k duration 145.90 (± 3.70 ms) 145.90 (± 4.30 ms) 0.00% 👌
table-clear-1k metric base(6ad3b7c) target(b493418) trend
benchmark-table/clear/1k duration 11.70 (± 0.40 ms) 11.50 (± 0.50 ms) 1.71% 👌
table-create-10k metric base(6ad3b7c) target(b493418) trend
benchmark-table/create/10k duration 855.90 (± 11.40 ms) 849.00 (± 8.70 ms) 0.81% 👍
table-create-1k metric base(6ad3b7c) target(b493418) trend
benchmark-table/create/1k duration 102.20 (± 1.20 ms) 101.70 (± 2.30 ms) 0.49% 👌
table-update-10th-1k metric base(6ad3b7c) target(b493418) trend
benchmark-table/update-10th/1k duration 86.70 (± 4.50 ms) 86.10 (± 5.20 ms) 0.69% 👌
tablecmp-append-1k metric base(6ad3b7c) target(b493418) trend
benchmark-table-component/append/1k duration 246.80 (± 4.70 ms) 246.90 (± 3.70 ms) -0.04% 👌
tablecmp-clear-1k metric base(6ad3b7c) target(b493418) trend
benchmark-table/clear/1k duration 31.80 (± 1.10 ms) 30.95 (± 0.95 ms) 2.67% 👌
tablecmp-create-10k metric base(6ad3b7c) target(b493418) trend
benchmark-table-component/create/10k duration 1706.70 (± 14.20 ms) 1681.00 (± 7.30 ms) 1.51% 👍
tablecmp-create-1k metric base(6ad3b7c) target(b493418) trend
benchmark-table-component/create/1k duration 190.90 (± 3.00 ms) 187.10 (± 5.10 ms) 1.99% 👍
tablecmp-update-10th-1k metric base(6ad3b7c) target(b493418) trend
benchmark-table-component/update-10th/1k duration 75.80 (± 4.20 ms) 75.00 (± 2.90 ms) 1.06% 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 6ad3b7c | Target commit: 9e046f5

lwc-engine-benchmark

table-append-1k metric base(6ad3b7c) target(9e046f5) trend
benchmark-table/append/1k duration 145.90 (± 3.70 ms) 150.80 (± 4.50 ms) -3.36% 👎
table-clear-1k metric base(6ad3b7c) target(9e046f5) trend
benchmark-table/clear/1k duration 11.70 (± 0.40 ms) 12.30 (± 0.60 ms) -5.13% 👎
table-create-10k metric base(6ad3b7c) target(9e046f5) trend
benchmark-table/create/10k duration 855.90 (± 11.40 ms) 852.60 (± 6.50 ms) 0.39% 👌
table-create-1k metric base(6ad3b7c) target(9e046f5) trend
benchmark-table/create/1k duration 102.20 (± 1.20 ms) 102.10 (± 2.15 ms) 0.10% 👌
table-update-10th-1k metric base(6ad3b7c) target(9e046f5) trend
benchmark-table/update-10th/1k duration 86.70 (± 4.50 ms) 87.80 (± 5.30 ms) -1.27% 👌
tablecmp-append-1k metric base(6ad3b7c) target(9e046f5) trend
benchmark-table-component/append/1k duration 246.80 (± 4.70 ms) 249.85 (± 4.05 ms) -1.24% 👎
tablecmp-clear-1k metric base(6ad3b7c) target(9e046f5) trend
benchmark-table/clear/1k duration 31.80 (± 1.10 ms) 33.35 (± 1.05 ms) -4.87% 👎
tablecmp-create-10k metric base(6ad3b7c) target(9e046f5) trend
benchmark-table-component/create/10k duration 1706.70 (± 14.20 ms) 1713.90 (± 7.80 ms) -0.42% 👎
tablecmp-create-1k metric base(6ad3b7c) target(9e046f5) trend
benchmark-table-component/create/1k duration 190.90 (± 3.00 ms) 191.40 (± 4.00 ms) -0.26% 👌
tablecmp-update-10th-1k metric base(6ad3b7c) target(9e046f5) trend
benchmark-table-component/update-10th/1k duration 75.80 (± 4.20 ms) 75.20 (± 3.40 ms) 0.79% 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 6ad3b7c | Target commit: 0c3b4cd

lwc-engine-benchmark

table-append-1k metric base(6ad3b7c) target(0c3b4cd) trend
benchmark-table/append/1k duration 145.90 (± 3.70 ms) 150.10 (± 4.80 ms) -2.88% 👎
table-clear-1k metric base(6ad3b7c) target(0c3b4cd) trend
benchmark-table/clear/1k duration 11.70 (± 0.40 ms) 12.20 (± 0.50 ms) -4.27% 👎
table-create-10k metric base(6ad3b7c) target(0c3b4cd) trend
benchmark-table/create/10k duration 855.90 (± 11.40 ms) 851.70 (± 5.60 ms) 0.49% 👌
table-create-1k metric base(6ad3b7c) target(0c3b4cd) trend
benchmark-table/create/1k duration 102.20 (± 1.20 ms) 102.50 (± 1.70 ms) -0.29% 👌
table-update-10th-1k metric base(6ad3b7c) target(0c3b4cd) trend
benchmark-table/update-10th/1k duration 86.70 (± 4.50 ms) 88.20 (± 5.70 ms) -1.73% 👌
tablecmp-append-1k metric base(6ad3b7c) target(0c3b4cd) trend
benchmark-table-component/append/1k duration 246.80 (± 4.70 ms) 202.30 (± 8.20 ms) 18.03% 👍
tablecmp-clear-1k metric base(6ad3b7c) target(0c3b4cd) trend
benchmark-table/clear/1k duration 31.80 (± 1.10 ms) 32.30 (± 1.40 ms) -1.57% 👎
tablecmp-create-10k metric base(6ad3b7c) target(0c3b4cd) trend
benchmark-table-component/create/10k duration 1706.70 (± 14.20 ms) 1707.10 (± 8.50 ms) -0.02% 👌
tablecmp-create-1k metric base(6ad3b7c) target(0c3b4cd) trend
benchmark-table-component/create/1k duration 190.90 (± 3.00 ms) 186.90 (± 4.50 ms) 2.10% 👍
tablecmp-update-10th-1k metric base(6ad3b7c) target(0c3b4cd) trend
benchmark-table-component/update-10th/1k duration 75.80 (± 4.20 ms) 77.80 (± 4.00 ms) -2.64% 👌

@apapko apapko changed the title [NOMERGE] don't merge this is a test fix(compiler): merge master with new template style injection May 19, 2018
@apapko apapko removed the nomerge label May 19, 2018
@apapko apapko merged commit bffafe1 into apapko/raptor-on-platform-compiler May 19, 2018
@pmdartus pmdartus deleted the apapko/style-retry branch June 18, 2018 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant