Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix condition for extracting children getter #1041

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

ravijayaramappa
Copy link
Contributor

Details

The condition to extract children descriptor from Element.prototype or HTMLElement.prototype has a bug. It is checking the wrong property
Backport of #1039

Does this PR introduce a breaking change?

  • Yes
  • No

@ravijayaramappa ravijayaramappa merged commit d3bbc72 into 218/patch Feb 6, 2019
@ravijayaramappa ravijayaramappa deleted the ravi/218/patch/child-getter/W-5832932 branch February 6, 2019 22:56
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 3dacbd7 | Target commit: cbf704d

lwc-engine-benchmark

table-append-1k metric base(3dacbd7) target(cbf704d) trend
benchmark-table/append/1k duration 151.20 (±4.75 ms) 150.25 (±3.85 ms) -0.9ms (0.6%) 👌
table-clear-1k metric base(3dacbd7) target(cbf704d) trend
benchmark-table/clear/1k duration 5.90 (±0.40 ms) 6.10 (±0.30 ms) +0.2ms (3.4%) 👎
table-create-10k metric base(3dacbd7) target(cbf704d) trend
benchmark-table/create/10k duration 875.05 (±5.45 ms) 915.65 (±4.80 ms) +40.6ms (4.6%) 👎
table-create-1k metric base(3dacbd7) target(cbf704d) trend
benchmark-table/create/1k duration 117.85 (±3.10 ms) 120.90 (±3.60 ms) +3.1ms (2.6%) 👎
table-update-10th-1k metric base(3dacbd7) target(cbf704d) trend
benchmark-table/update-10th/1k duration 83.80 (±3.15 ms) 77.15 (±3.00 ms) -6.6ms (7.9%) 👌
tablecmp-append-1k metric base(3dacbd7) target(cbf704d) trend
benchmark-table-component/append/1k duration 235.80 (±18.30 ms) 255.75 (±6.60 ms) +19.9ms (8.5%) 👎
tablecmp-clear-1k metric base(3dacbd7) target(cbf704d) trend
benchmark-table-component/clear/1k duration 12.10 (±1.90 ms) 12.85 (±1.55 ms) +0.8ms (6.2%) 👌
tablecmp-create-10k metric base(3dacbd7) target(cbf704d) trend
benchmark-table-component/create/10k duration 1731.95 (±10.80 ms) 1752.00 (±11.55 ms) +20.0ms (1.2%) 👎
tablecmp-create-1k metric base(3dacbd7) target(cbf704d) trend
benchmark-table-component/create/1k duration 206.80 (±3.40 ms) 212.95 (±5.15 ms) +6.1ms (3.0%) 👎
tablecmp-update-10th-1k metric base(3dacbd7) target(cbf704d) trend
benchmark-table-component/update-10th/1k duration 71.25 (±4.55 ms) 71.55 (±4.65 ms) +0.3ms (0.4%) 👌
wc-append-1k metric base(3dacbd7) target(cbf704d) trend
benchmark-table-wc/append/1k duration 257.95 (±4.70 ms) 260.40 (±5.35 ms) +2.4ms (0.9%) 👎
wc-clear-1k metric base(3dacbd7) target(cbf704d) trend
benchmark-table-wc/clear/1k duration 22.05 (±1.80 ms) 22.50 (±2.15 ms) +0.5ms (2.0%) 👌
wc-create-10k metric base(3dacbd7) target(cbf704d) trend
benchmark-table-wc/create/10k duration 1992.90 (±15.65 ms) 2015.80 (±9.60 ms) +22.9ms (1.1%) 👎
wc-create-1k metric base(3dacbd7) target(cbf704d) trend
benchmark-table-wc/create/1k duration 220.95 (±4.15 ms) 228.50 (±5.25 ms) +7.6ms (3.4%) 👎
wc-update-10th-1k metric base(3dacbd7) target(cbf704d) trend
benchmark-table-wc/update-10th/1k duration 68.65 (±4.95 ms) 73.05 (±5.65 ms) +4.4ms (6.4%) 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants