You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unmount handles vfragment correctly. Reading the comments above resetComponentRoot, it does not want to call unmount for perf reasons. So, I suggest we can replicate that same special handling for VFragment in resetComponentRoot.
jye-sf
changed the title
fix: @W-12593632 clean up VFragments when resetting component root
fix: clean up VFragments when resetting component root
Feb 24, 2023
⚪️ Check PR user has rights to execute the workflow(skipped)
Skipping PR owner check since PR has already been merged.
✅ Check PR is approved
PR 3360 is approved
⚪️ Check PR is mergeable(skipped)
PR 3360 has already been merged
⚠️Check GUS reference is present
PR does not contain a reference to a GUS work item. You can update it any time by including '@W-XXXXXXX' into the title or body of the PR
❌ Check no conflicting Github release
A Github release already exists with a tag of v2.31.6. Please commit/push a version bump to the jye/fix-render-reset branch or have Nucleus do it for you by responding with the following comment /nucleus bump-version [version]
To skip this check, run /nucleus release --force
❌ Check NPM packages have not been released yet
Version 2.31.6 of this project has already been published. If you would like to skip NPM publishing, then run /nucleus release --skipNpmRelease.If you want to bump the version in your source branch, run /nucleus bump-version [version]
⚪️ Check Maven artifacts have not been released yet(skipped)
Skipping check since project doesn't deliver Maven artifacts
⚪️ Check GAV mapping exists for jar repo(skipped)
Skipping GAV mapping check because a core jar is not being released.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jye-sf
force-pushed
the
jye/fix-render-reset
branch
from
Details
VFragments are not cleaned up properly when resetting component root because their
.elmpoints to the end delimiter text node, not the root element.Backport of #3363.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item