-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use consistent build process across packages #3456
Changes from all commits
7bb8d01
e0c903c
393f07c
77c50d8
ae28f47
afc0779
5a466c4
e93ee62
6229d5c
11912aa
3a8ec8d
e83ff66
6e1dc2c
2fbfb14
31526df
a9c17f6
0672ad6
e89c0ec
b3a0b20
d3c2f92
37269a6
e65f997
d96251e
13af442
a0bf6df
3809231
8d23ba6
afaf07f
8e6ecb6
089cd4a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,5 +27,9 @@ | |
}, | ||
"affected": { | ||
"defaultBase": "master" | ||
}, | ||
"namedInputs": { | ||
"sharedGlobals": ["{workspaceRoot}/scripts/rollup/rollup.config.js"], | ||
"default": ["{projectRoot}/**/*", "sharedGlobals"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This tells NX that when this file changes, it should bust the cache |
||
} | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,6 @@ | |
"extends": "../../../tsconfig.json", | ||
|
||
"compilerOptions": { | ||
"outDir": ".", | ||
"lib": ["dom", "es2018"] | ||
}, | ||
|
||
|
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,6 @@ | |
"extends": "../../../tsconfig.json", | ||
|
||
"compilerOptions": { | ||
"outDir": ".", | ||
"lib": ["es2018"] | ||
}, | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,4 +15,4 @@ export { | |
OutputConfig, | ||
} from './options'; | ||
|
||
export const version = '__VERSION__'; | ||
export const version = process.env.LWC_VERSION as string; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We were already using |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,5 @@ | ||
{ | ||
"extends": "../../../tsconfig.json", | ||
|
||
"compilerOptions": { | ||
"outDir": "dist/commonjs", | ||
"declarationDir": "dist/types" | ||
}, | ||
|
||
"include": ["src/", "typings/"] | ||
"include": ["src/"] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should run as part of Husky, so it shouldn't get out of sync, but this is just a failsafe.