fix: add proxy-compat comment back to dist files #3526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
May 22, 2023
| @@ -21,7 +21,8 @@ const commonjs = require('@rollup/plugin-commonjs'); | |||
| const packageRoot = process.cwd(); | |||
| const packageJson = JSON.parse(readFileSync(path.resolve(packageRoot, './package.json'), 'utf-8')); | |||
| const { name: packageName, version, dependencies, peerDependencies } = packageJson; | |||
| const banner = `/**\n * Copyright (C) 2023 salesforce.com, inc.\n */`; | |||
| // proxy-compat-disable tells compat mode not to apply - framework files aren't designed for the compat transform | |||
| const banner = `/* proxy-compat-disable */\n/**\n * Copyright (C) 2023 salesforce.com, inc.\n */`; | |||
There was a problem hiding this comment.
Only 4 files matter to lwc-platform: engine-dom, engine-server, synthetic-shadow, and wire-service.
If you check the old bundle files that lwc-platform was using (esm/2017), all of them have proxy-compat-disable except for wire-service.
Looking at wire-service, I don't think it matters either way whether it has the comment or not, so we can just be consistent everywhere.
ravijayaramappa
approved these changes
May 22, 2023
jye-sf
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This accidentally got removed in #3456, but we need it on platform.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
W-13402515