feat(compiler): return cssScopeTokens #3556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulsattar
approved these changes
Jun 6, 2023
| @@ -23,6 +23,7 @@ export interface TransformResult { | |||
| code: string; | |||
| map: unknown; | |||
| warnings?: CompilerDiagnostic[]; | |||
| cssScopeTokens?: string[]; | |||
There was a problem hiding this comment.
Only the template compiler returns it, not the style compiler or babel compiler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This adds an explicit
cssScopeTokensreturn value fortransformSyncin@lwc/compiler. This would be a cleaner way forlwc-testto know which scope tokens are being generated by the template compiler.E.g. if you look at salesforce/lwc-test#184, you can see that I have to do a regex-search on the code returned by
@lwc/compilerto detect and replace the scope tokens. This is ugly; we should just have the compiler return the scope tokens explicitly.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
W-12425100