chore: remove legacy dist files (BREAKING CHANGE)

[nolanlawson]

Details

Fixes #3445. Removes legacy dist/ files from the npm package.

Does this pull request introduce a breaking change?

• 🚨 Yes, it does introduce a breaking change.

The following will no longer work:

require('@lwc/compiler/dist/commonjs/transformers/transformer.js')
require('@lwc/engine-dom/dist/engine-dom.js')
require('@lwc/synthetic-shadow/dist/synthetic-shadow.js')

Instead of a deep require(), do this:

require('@lwc/compiler')
require('@lwc/engine-dom')
require('@lwc/synthetic-shadow')

Does this pull request introduce an observable change?

• ⚠️ Yes, it does include an observable change.

[divmain]

I believe there are consumers that still use this pattern: require('@lwc/compiler/dist/commonjs/transformers/transformer.js'). Is this a just nice-to-have for 3.0.0? If so, I'd push for holding off on this change, as I believe it will be disruptive.

Nolan and I chatted about this, and he rightly pointed out that the blast radius is significantly lessened for folks that control their NPM dependencies directly. Because of that, I withdraw my opposition.