Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing shadowRoot property from elements #371

Merged
merged 2 commits into from
Jun 3, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Jun 3, 2018

Details

Disabling shadowRoot property since its implementation is incomplete and we have a lot of test failures due to WebDriver shadow expectations.

@diervo diervo merged commit fb1e968 into master Jun 3, 2018
@diervo diervo deleted the dval/disableShadowDOMProp branch June 3, 2018 06:28
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: ac0ca90 | Target commit: 48e4266

lwc-engine-benchmark

table-append-1k metric base(ac0ca90) target(48e4266) trend
benchmark-table/append/1k duration 144.10 (± 5.00 ms) 146.40 (± 4.10 ms) -1.60% 👎
table-clear-1k metric base(ac0ca90) target(48e4266) trend
benchmark-table/clear/1k duration 11.30 (± 0.30 ms) 11.70 (± 0.50 ms) -3.54% 👌
table-create-10k metric base(ac0ca90) target(48e4266) trend
benchmark-table/create/10k duration 848.00 (± 3.70 ms) 841.00 (± 6.60 ms) 0.83% 👍
table-create-1k metric base(ac0ca90) target(48e4266) trend
benchmark-table/create/1k duration 102.40 (± 2.10 ms) 101.10 (± 1.00 ms) 1.27% 👌
table-update-10th-1k metric base(ac0ca90) target(48e4266) trend
benchmark-table/update-10th/1k duration 88.15 (± 5.40 ms) 88.60 (± 5.30 ms) -0.51% 👌
tablecmp-append-1k metric base(ac0ca90) target(48e4266) trend
benchmark-table-component/append/1k duration 252.50 (± 4.60 ms) 253.50 (± 5.00 ms) -0.40% 👌
tablecmp-clear-1k metric base(ac0ca90) target(48e4266) trend
benchmark-table/clear/1k duration 35.30 (± 1.60 ms) 35.50 (± 1.40 ms) -0.57% 👌
tablecmp-create-10k metric base(ac0ca90) target(48e4266) trend
benchmark-table-component/create/10k duration 1693.30 (± 9.80 ms) 1676.00 (± 8.70 ms) 1.02% 👍
tablecmp-create-1k metric base(ac0ca90) target(48e4266) trend
benchmark-table-component/create/1k duration 196.80 (± 4.00 ms) 198.20 (± 4.00 ms) -0.71% 👌
tablecmp-update-10th-1k metric base(ac0ca90) target(48e4266) trend
benchmark-table-component/update-10th/1k duration 75.50 (± 4.50 ms) 74.10 (± 4.70 ms) 1.85% 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant